Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of disconnect with NSDisconnectPlayer #841

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Replace uses of disconnect with NSDisconnectPlayer #841

merged 6 commits into from
Nov 4, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 22, 2024
@ASpoonPlaysGames ASpoonPlaysGames mentioned this pull request Aug 22, 2024
Open
Zanieon
Zanieon approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tested in my local build with no downsides.

@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 2, 2024
@GeckoEidechse GeckoEidechse changed the title Replace uses of "disconnect" with NSDisconnectPlayer Replace uses of disconnect with NSDisconnectPlayer Oct 6, 2024
@GeckoEidechse GeckoEidechse merged commit 730616d into R2Northstar:main Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zanieon Zanieon Zanieon approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @Zanieon @GeckoEidechse