Add JSON-LD to guess_format() #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the `rdflib` package provides the functionality formerly in the package `rdflib-jsonld`, it would be helpful for the utility function `guess_format` to recognize file extensions indicative of JSON-LD content. This patch adds recognition of two file extensions, preserving syntax of the `SUFFIX_FORMAT_MAP` variable: * `.json` * `.jsonld` The latter is in recognition of the IANA media type `application/ld+json` reporting the `.jsonld` file extension. References: https://www.iana.org/assignments/media-types/application/ld+json via https://www.iana.org/assignments/media-types/media-types.xhtml via https://w3c.github.io/json-ld-syntax/#iana-considerations Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
Good update. Happy to merge. Though this is simple, please next time add a test too, even if trivial? Thanks! |
|
Ah, I apologize, I had delegated the test to the docstring, thinking a docstrings test would pick it up. I think I see where to add the test now. I'll add a follow-on PR. |
ajnelson-nist
added a commit
to casework/CASE-Utilities-Python
that referenced
this pull request
Sep 28, 2021
rdflib 6.0.1 upgraded `guess_format()` to report JSON-LD (via PRs 1403 and 1408). With the functionality upstream, this patch moves towards completing tech. transfer by deprecating the local implementation. References: * RDFLib/rdflib#1403 * RDFLib/rdflib#1408 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
rdflibpackage provides the functionality formerly in thepackage
rdflib-jsonld, it would be helpful for the utility functionguess_formatto recognize file extensions indicative of JSON-LDcontent.
This patch adds recognition of two file extensions, preserving syntax of
the
SUFFIX_FORMAT_MAPvariable:.json.jsonldThe latter is in recognition of the IANA media type
application/ld+jsonreporting the.jsonldfile extension.References:
https://www.iana.org/assignments/media-types/application/ld+json
via https://www.iana.org/assignments/media-types/media-types.xhtml
via https://w3c.github.io/json-ld-syntax/#iana-considerations
Signed-off-by: Alex Nelson alexander.nelson@nist.gov
Proposed Changes
guess_format