Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for adding JSON-LD to guess_format() #1408

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Add test for adding JSON-LD to guess_format() #1408

merged 1 commit into from
Sep 17, 2021

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Sep 10, 2021 •
edited
Loading

This is a follow-on patch to:
e778e94

Test was confirmed to pass by running this on the current master
branch, and confirmed to fail with e778e94 reverted.

nosetests test/test_parse_file_guess_format.py

Signed-off-by: Alex Nelson alexander.nelson@nist.gov

Proposed Changes

  • Adds unit test to confirm JSON-LD example parses without format hint assistance.

@ajnelson-nist
Add test for adding JSON-LD to guess_format()
700f6e6 
This is a follow-on patch to:
e778e94

Test was confirmed to pass by running this on the current `master`
branch, and confirmed to fail with e778e94 reverted.

    nosetests test/test_parse_file_guess_format.py

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@nicholascar nicholascar merged commit dad85e6 into RDFLib:master Sep 17, 2021
@ajnelson-nist ajnelson-nist deleted the test-adding-json-ld-to-guess-format branch September 17, 2021 14:40
ajnelson-nist added a commit to casework/CASE-Utilities-Python that referenced this pull request Sep 28, 2021
@ajnelson-nist
Bump rdflib dependency to 6.0.1, deprecating local guess_format
ce43114 
rdflib 6.0.1 upgraded `guess_format()` to report JSON-LD (via PRs 1403
and 1408).  With the functionality upstream, this patch moves towards
completing tech. transfer by deprecating the local implementation.

References:
* RDFLib/rdflib#1403
* RDFLib/rdflib#1408

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Utilities-Python that referenced this pull request Sep 28, 2021
@ajnelson-nist
Remove 'format=' parameter from graph parse() and serialize() calls
eeae6ac 
rdflib 6.0.0 improved filename-based format recognition.  (Tests for
recognition were upgraded to support JSON-LD in PR 1408.)

This patch removes explicit-but-redundant functionality.

References:
* RDFLib/rdflib#1408

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnelson-nist @nicholascar