Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARQLStore graph awareness #402

Merged
merged 4 commits into from
Jul 10, 2014
Merged

SPARQLStore graph awareness #402

merged 4 commits into from
Jul 10, 2014

Conversation

bcogrel
Copy link
Contributor

@bcogrel bcogrel commented Jun 12, 2014

Here is a proposal for making SPARQLStore and SPARQLUpdateStore be graph_aware (see issue #399).

Two new methods add_graph and remove_graph have been added to these classes. They raise a read-only error when simple SPARQLStore are used. The SPARQLUpdateStore uses the CREATE and DROP SPARQL commands.

The default graph of the Dataset is the default graph of the SPARQL endpoint.

To test it, I have adapted test_dataset. However, the SPARQL endpoint configuration it requires is in conflict with test_sparqlupdatestore. Indeed the latter wants an union default graph (like tdb:unionDefaultGraph) that may cause the default graph to be read-only while the former tests the "non union" and writes into the default graph. Any suggestion? Should we execute these tests manually one by one? Remind that tests are skipped if no endpoint is available.

Please note that commits of #401 have also been included in this patch.

@gromgull
Copy link
Member

Thanks a lot!

As you say - the tests are anyway not run automatically, and will have to be run by people who have setup fuseki or similar. I think your printed warnings are good enough!

gromgull added a commit that referenced this pull request Jul 10, 2014
@gromgull gromgull merged commit d70e84c into RDFLib:master Jul 10, 2014
@bcogrel
Copy link
Contributor Author

bcogrel commented Jul 10, 2014

Great! Happy to hear that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants