Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal for making
SPARQLStore
andSPARQLUpdateStore
begraph_aware
(see issue #399).Two new methods
add_graph
andremove_graph
have been added to these classes. They raise a read-only error when simpleSPARQLStore
are used. TheSPARQLUpdateStore
uses theCREATE
andDROP
SPARQL commands.The default graph of the
Dataset
is the default graph of the SPARQL endpoint.To test it, I have adapted
test_dataset
. However, the SPARQL endpoint configuration it requires is in conflict withtest_sparqlupdatestore
. Indeed the latter wants an union default graph (liketdb:unionDefaultGraph
) that may cause the default graph to be read-only while the former tests the "non union" and writes into the default graph. Any suggestion? Should we execute these tests manually one by one? Remind that tests are skipped if no endpoint is available.Please note that commits of #401 have also been included in this patch.