-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kconfig: Expose gnrc/ipv6/whitelist configurations #12893
Kconfig: Expose gnrc/ipv6/whitelist configurations #12893
Conversation
Macros that changed: GNRC_IPV6_WHITELIST_SIZE -> CONFIG_GNRC_IPV6_WHITELIST_SIZE
#ifndef GNRC_IPV6_WHITELIST_SIZE | ||
#define GNRC_IPV6_WHITELIST_SIZE (8) | ||
#ifndef CONFIG_GNRC_IPV6_WHITELIST_SIZE | ||
#define CONFIG_GNRC_IPV6_WHITELIST_SIZE (8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to rename all config macros to be usable with kconfig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Kconfig generates the .config and .h files appending the CONFIG_
symbol. Regardless of that, I think it's good to have configuration macros under a single namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, were just wondering for future integrations.
I set the whitelist size to 100 via menuconfig and applied the following patch:
The output is
So, it works as expected. |
implementation of KConfig files looks also good. It should be easy to proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK on my side. @miri64 do you have something to add?
Nope all good from my side. Murdock seems to have failed on an unrelated error though. |
Contribution description
This moves the
gnrc_ipv6_whitelist
module configuration macros to theCONFIG_
namespace and exposes them to Kconfig.Testing procedure
Compile
gnrc_networking
example application using this module (USEMODULE=gnrc_ipv6_whitelist make all term
), the default configuration should still be the same.Call menuconfig using this module (
USEMODULE=gnrc_ipv6_whitelist make menuconfig
), you should the list size as an option. The default list size should still be the same. If you change the value it should change in the app.Issues/PRs references
Part of #12888