Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kconfig: Expose gnrc/ipv6/blacklist configurations #12922

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Kconfig: Expose gnrc/ipv6/blacklist configurations #12922

merged 2 commits into from
Dec 20, 2019

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

Like #12893, this moves the gnrc_ipv6_blacklist module configuration macros to the CONFIG_ namespace and exposes them to Kconfig.

Testing procedure

  • Compile gnrc_networking example application using this module (USEMODULE=gnrc_ipv6_blacklist make all term), the default configuration should still be the same.

  • Call menuconfig using this module (USEMODULE=gnrc_ipv6_blacklist make menuconfig), you should the list size as an option. The default list size should still be the same. If you change the value it should change in the app.

Issues/PRs references

Part of #12888

@leandrolanzieri leandrolanzieri added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force labels Dec 11, 2019
@leandrolanzieri leandrolanzieri added this to the Release 2020.01 milestone Dec 11, 2019
@leandrolanzieri leandrolanzieri mentioned this pull request Dec 11, 2019
Open
71 tasks
@jia200x
Copy link
Member

jia200x commented Dec 20, 2019

Works as expected. Thanks!

jia200x
jia200x approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. The symbol is generated as expected (this is analog to #12893 so I used the same test procedure). ACK

@jia200x jia200x merged commit 7d4082a into RIOT-OS:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @jia200x