Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/nucleo144-f446: add initial support #6553

Merged
merged 3 commits into from
Mar 17, 2017

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 3, 2017

I also have this one on my desk :)

It has small differences with the nucleo-f446 (64 pins).

@aabadie aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Feb 3, 2017
@aabadie aabadie added this to the Release 2017.04 milestone Feb 3, 2017
@kYc0o
Copy link
Contributor

kYc0o commented Mar 15, 2017

@astralien3000 If you have time could you test this board? Code looks OK. While testing can you also run the unittests? (in tests/unittests, make flash term)

@aabadie
Copy link
Contributor Author

aabadie commented Mar 15, 2017

@kYc0o, I fixed a build issue since #6714 is now merged and also removed the commit related to saul (since #6705 will do that)

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 15, 2017
@kYc0o
Copy link
Contributor

kYc0o commented Mar 15, 2017

OK, let's see what Murdock says.

@astralien3000
Copy link
Member

I tested default, and I can't get the user button's state with saul.

@aabadie
Copy link
Contributor Author

aabadie commented Mar 15, 2017

This is because it's not exported via Saul. Only LED0 is for the moment. #6705 will do that.

@astralien3000
Copy link
Member

astralien3000 commented Mar 16, 2017

@kYc0o, are the unittests supposed to print something ?

EDIT: because it does not print any dot like native

@astralien3000
Copy link
Member

I tested default, periph_uart, periph_timer and xtimer_usleep, everything is ok

@aabadie
Copy link
Contributor Author

aabadie commented Mar 16, 2017

@astralien3000, the button issue can be related to this comment because it is actually exposed via saul. #6705 will fix this BTW.
I also noticed a wrong alphabetical order of the features exposed by the board. Will fix.

@kYc0o
Copy link
Contributor

kYc0o commented Mar 16, 2017

@astralien3000 yes it should print that all test passed, if not, something is wrong and we need to see what.

@aabadie
Copy link
Contributor Author

aabadie commented Mar 16, 2017

@astralien3000 I rebased on latest master with #6705 inside. The button should work with saul and 3 leds are also exposed. Can you try again ?

@astralien3000
Copy link
Member

@aabadie, done, everything is ok with saul in default example
@kYc0o, so, unittests is not working

@kYc0o kYc0o added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 16, 2017
@astralien3000
Copy link
Member

I retested unittests with the newest commits, and everything is good

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 16, 2017
Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@aabadie
Copy link
Contributor Author

aabadie commented Mar 17, 2017

@kYc0o, I think you can now press the green button, right ?

@kYc0o
Copy link
Contributor

kYc0o commented Mar 17, 2017

If everything is good, let's go.

@kYc0o kYc0o merged commit 80e7ab5 into RIOT-OS:master Mar 17, 2017
@aabadie aabadie deleted the nucleo144-f446 branch February 26, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants