-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/nucleo144-f446: add initial support #6553
Conversation
f1ba579
to
4b7f2aa
Compare
@astralien3000 If you have time could you test this board? Code looks OK. While testing can you also run the unittests? (in tests/unittests, |
OK, let's see what Murdock says. |
I tested |
This is because it's not exported via Saul. Only LED0 is for the moment. #6705 will do that. |
@kYc0o, are the unittests supposed to print something ? EDIT: because it does not print any dot like native |
I tested default, periph_uart, periph_timer and xtimer_usleep, everything is ok |
@astralien3000, the button issue can be related to this comment because it is actually exposed via saul. #6705 will fix this BTW. |
@astralien3000 yes it should print that all test passed, if not, something is wrong and we need to see what. |
@astralien3000 I rebased on latest master with #6705 inside. The button should work with saul and 3 leds are also exposed. Can you try again ? |
I retested unittests with the newest commits, and everything is good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
@kYc0o, I think you can now press the green button, right ? |
If everything is good, let's go. |
I also have this one on my desk :)
It has small differences with the nucleo-f446 (64 pins).