Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nucleo144-f429: initial support #6594

Merged
merged 3 commits into from
Mar 24, 2017
Merged

boards/nucleo144-f429: initial support #6594

merged 3 commits into from
Mar 24, 2017

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 13, 2017

This PR adds support for another nucleo 144 board, the nucleo144-F429. Similar to the nucleo-f207, this board has an ethernet connector available via the MII periph of the MCU but it's not supported for the moment.

It's mainly copy pasted from #6553. Before opening this PR, I just tested the timer, hwrng and uart with success.

@aabadie aabadie added Area: drivers Area: Device drivers Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Feb 13, 2017
@aabadie aabadie added this to the Release 2017.04 milestone Feb 13, 2017
@PeterKietzmann PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties labels Feb 16, 2017
@aabadie
Copy link
Contributor Author

aabadie commented Mar 1, 2017

@kYc0o, if you to test, I think you have some in your office ;)

@aabadie aabadie mentioned this pull request Mar 6, 2017
Merged
@aabadie aabadie force-pushed the nucleo144_f429 branch 2 times, most recently from 3c5c4d6 to 9ab7167 Compare March 8, 2017 21:08
@aabadie aabadie mentioned this pull request Mar 8, 2017
Open
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 14, 2017
@kYc0o
Copy link
Contributor

kYc0o commented Mar 15, 2017

Code looks OK here too, just fix the errors spotted by Murdock.

@aabadie aabadie force-pushed the nucleo144_f429 branch 3 times, most recently from 2fe469d to bb038ce Compare March 15, 2017 13:16
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 15, 2017
@aabadie aabadie force-pushed the nucleo144_f429 branch 2 times, most recently from 467bc49 to a126296 Compare March 16, 2017 17:29
@aabadie aabadie added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 16, 2017
@aabadie
Copy link
Contributor Author

aabadie commented Mar 20, 2017

ping @kYc0o

@astralien3000
Copy link
Member

Tested default (saul leds+button), periph_timer, periph_pwm, periph_uart, xtimer_usleep.
Everything is ok.

@aabadie
Copy link
Contributor Author

aabadie commented Mar 24, 2017

ping @kYc0o, can you ACK ?

kYc0o
kYc0o approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kYc0o kYc0o merged commit ffad15f into RIOT-OS:master Mar 24, 2017
@aabadie aabadie deleted the nucleo144_f429 branch February 26, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kYc0o kYc0o kYc0o approved these changes

Assignees

@haukepetersen haukepetersen

@vincent-d vincent-d

@kYc0o kYc0o

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2017.04
Development

Successfully merging this pull request may close these issues.
7 participants
@aabadie @kYc0o @astralien3000 @haukepetersen @vincent-d @kaspar030 @PeterKietzmann