This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
sniffer: use argparse to parse script arguments #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2018
bergzand
reviewed
Jun 19, 2018
sniffer/tools/sniffer.py
Outdated
| help="Port of the TCP-based sniffer application") | ||
| p.add_argument("channel", type=int, help="Channel to sniff on") | ||
| p.add_argument("outfile", type=str, default=None, nargs="?", | ||
| help="PCAP file to output to") |
There was a problem hiding this comment.
There is an argparse.FileType in python.
|
please squash |
This is mainly a preparation step to make some arguments (namely baudrate and the "serial/socket" argument) optional, to make it more usable like the old `rftest2pcap` script for the econotag.
miri64
force-pushed
the
sniffer/enh/argparse
branch
from
5af8d96 to
fb79b79
Compare
|
Squashed |
This was referenced Sep 26, 2018
Closed
chrysn
pushed a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
Sep 20, 2022
…gparse sniffer: use argparse to parse script arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a preparation step to make some arguments (namely
baudrate and the "serial/socket" argument) optional, to make it more
usable like the old
rftest2pcapscript for the econotag.(it also makes the script code more readable)