This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
sniffer: make baudrate optional #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
reviewed
Jun 19, 2018
sniffer/tools/sniffer.py
Outdated
| help="Port of the TCP-based sniffer application") | ||
| p.add_argument("channel", type=int, help="Channel to sniff on") | ||
| p.add_argument("outfile", type=str, default=None, nargs="?", | ||
| help="PCAP file to output to") |
There was a problem hiding this comment.
There is argparse.FileType to handle file arguments in python.
There was a problem hiding this comment.
This change is part of #37. (sorry, did not make clear this PR depends on that)
There was a problem hiding this comment.
Ah, that explains why my comment didn't show up at #37, I meant to place it there :)
miri64
added a commit
to miri64/RIOT_applications
that referenced
this pull request
Jun 19, 2018
The KISS approach alternative to RIOT-OS#38 (also includes RIOT-OS#39, because...). Disadvantage: we loose backwards compatibility for this tool.
miri64
added a commit
to miri64/RIOT_applications
that referenced
this pull request
Jun 19, 2018
The KISS approach alternative to RIOT-OS#38 (also includes RIOT-OS#39, because...). Disadvantage: we loose backwards compatibility for this tool.
miri64
force-pushed
the
sniffer/enh/baudrate-optional
branch
from
eba0b12 to
5017bea
Compare
|
Rebased. |
miri64
added a commit
to miri64/RIOT_applications
that referenced
this pull request
Jul 13, 2018
The KISS approach alternative to RIOT-OS#38 (also includes RIOT-OS#39, because...). Disadvantage: we loose backwards compatibility for this tool.
chrysn
pushed a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
Sep 20, 2022
…udrate-optional sniffer: make baudrate optional
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #37