added fake_node pkg, tb3_house #90

JaehyunShim · 2019-09-09T01:54:46Z

No description provided.

robotpilot · 2019-09-09T02:31:21Z

@rjshim
From next PR, raise PR from your special branch to ros2-devel. ros2 is the branch we work on for release.

routiful

I attached some comment.
Best regards

turtlebot3_fake_node/CMakeLists.txt

turtlebot3_fake_node/src/turtlebot3_fake_node.cpp

turtlebot3_fake_node/launch/turtlebot3_fake_node.launch.py

turtlebot3_fake_node/package.xml

routiful · 2019-09-09T02:33:29Z

@rjshim Please check your files to pass CI. And describe what is changed this PR.

JaehyunShim · 2019-09-09T02:36:51Z

@robotpilot I didn't know how the system works. I will close this PR and reupload it.
@routiful I will. Thanks!

Ryan

robotpilot · 2019-09-09T02:32:19Z

turtlebot3_fake_node/include/turtlebot3_fake_node/turtlebot3_fake_node.hpp

+* limitations under the License.
+*******************************************************************************/
+
+/* Authors: Yoonseok Pyo */


add your name to Authors list

robotpilot · 2019-09-09T02:33:33Z

turtlebot3_fake_node/launch/rviz2.launch.py

@@ -0,0 +1,39 @@
+# /*******************************************************************************


This comment is a mixture of Python and C ++. Please use Python comments.

robotpilot · 2019-09-09T02:33:59Z

turtlebot3_fake_node/launch/turtlebot3_fake_node.launch.py

@@ -0,0 +1,78 @@
+# /*******************************************************************************


This comment is a mixture of Python and C ++. Please use Python comments.

robotpilot · 2019-09-09T02:35:15Z

turtlebot3_fake_node/launch/turtlebot3_fake_node.launch.py

+        Node(
+            package='turtlebot3_fake_node',
+            node_executable='turtlebot3_fake_node',
+            # node_name='tb3_fake_node',


Why is node_name commented?

robotpilot · 2019-09-09T02:36:33Z

turtlebot3_fake_node/param/burger.yaml

+    joint_states_frame: "base_footprint"
+    odom_frame: "odom"
+    base_frame: "base_footprint"
+


There is no EOF.

robotpilot · 2019-09-09T02:36:39Z

turtlebot3_fake_node/param/waffle.yaml

+    joint_states_frame: "base_footprint"
+    odom_frame: "odom"
+    base_frame: "base_footprint"
+


There is no EOF.

robotpilot · 2019-09-09T02:36:44Z

turtlebot3_fake_node/param/waffle_pi.yaml

+    joint_states_frame: "base_footprint"
+    odom_frame: "odom"
+    base_frame: "base_footprint"
+


There is no EOF.

robotpilot · 2019-09-09T02:38:08Z

turtlebot3_fake_node/src/turtlebot3_fake_node.cpp

+void Turtlebot3Fake::init_variables()
+{
+  // Initialise variables
+  wheel_speed_cmd_[LEFT]  = 0.0;


Delete unnecessary indents.

JaehyunShim · 2019-09-09T05:15:19Z

Added the following modifications.

test lines removed from CMakeLists.txt
unnecessary indentations removed
author name added
missing empty lines added to EOF
python file format edited (tested with ament_flake8)
rviz config changed (background colour changed to white, tf display disabled)

robotpilot · 2019-09-09T05:32:54Z

The current CI may fail depending on the ROS Distro update situation.
The next ROS Distro update for ROS 2 Dashing will be September 10th, so this PR's merge will continue after 10th.

Signed-off-by: Pyo <pyo@robotis.com>

robotpilot

Good! Please correct some of the comments mentioned above.

turtlebot3_fake_node/src/turtlebot3_fake_node.cpp

…tions into ros2-devel

Signed-off-by: Pyo <pyo@robotis.com>

robotpilot · 2019-09-11T05:01:53Z

Today ROS 2 Dashing patch 3 has been released, and ROS 2 packages are synced. I modified CI settings for ROS 2 Dashing patch 3 and dependency packages.

https://discourse.ros.org/t/new-packages-and-patch-release-for-ros-2-dashing-diademata-2019-09-10/10627

routiful · 2019-09-11T05:05:08Z

@rjshim After commit to fix your code, please comment on each conversation. That makes reviewer would be more easy to check what you fixed.

JaehyunShim · 2019-09-11T05:54:45Z

@routiful Thank you for the advice 👍

Added the following modifications.

Lines with seconds() have been changed to use nanoseconds() in the turtlebot3_fake_node package. ref

robotpilot · 2019-09-16T01:24:52Z

Build Status

ros2-devel	ros2	Dashing + Ubuntu Bionic

robotpilot · 2019-09-16T01:43:34Z

@rjshim I'm working on a release. Please correct the last @routiful's comment.

routiful · 2019-09-16T01:56:06Z

@rjshim
I think package name and launch file name should be correct to ROS 1 version

http://emanual.robotis.com/docs/en/platform/turtlebot3/simulation/#turtlebot3-simulation-using-fake-node

JaehyunShim · 2019-09-16T02:42:33Z

@routiful

I actually thought about it and what I thought was the current name (fake_node rather than fake) can better express what the package is (also, eManual for ROS 2 can be written differently from ROS 1).

If that name is commonly used for mobile robots in general or the author who originally wrote it wants it that way, I will just follow the advice and reupload the package. @robotpilot

The modification made for this will be uploaded together.

Regards,
Ryan

robotpilot · 2019-09-16T03:34:59Z

@rjshim I accept your opinion. Please proceed with the changed name.

…tions into ros2-devel

JaehyunShim · 2019-09-16T05:09:09Z

@robotpilot @routiful Thank you for the advice. I kept the name 'turtlebot3_fake_node' for the package name and launch file name. Here are the changes made.

rclcpp::Node::now() are used instead of rclcpp::Clock::now() as advised.

Ryan Shim added 4 commits September 9, 2019 10:51

fake_node package added

ca29527

tb3_house added to gazebo pkg

79615b3

pkg.xml modified

c4d16ec

minor changes

021b816

routiful requested review from routiful and robotpilot September 9, 2019 02:15

routiful assigned robotpilot Sep 9, 2019

robotpilot added the enhancement label Sep 9, 2019

routiful reviewed Sep 9, 2019

View reviewed changes

robotpilot requested changes Sep 9, 2019

View reviewed changes

JaehyunShim closed this Sep 9, 2019

Ryan Shim added 5 commits September 9, 2019 13:49

test lines removed

9c98566

unnecessary indentations removed, authorname added

aced7cb

empty line to EOF

8734a20

adjusted py file formatting

8bdc3eb

rviz map config changed

925efc6

JaehyunShim reopened this Sep 9, 2019

robotpilot added 3 commits September 10, 2019 07:39

Updated the CHANGELOG and version to release binary packages

41c9b76

Signed-off-by: Pyo <pyo@robotis.com>

Trimmed trailing whitespace

3e4b8a3

Signed-off-by: Pyo <pyo@robotis.com>

Updated the CHANGELOG and version to release binary packages

685fcbd

Signed-off-by: Pyo <pyo@robotis.com>

robotpilot requested changes Sep 9, 2019

View reviewed changes

turtlebot3_fake_node/src/turtlebot3_fake_node.cpp Outdated Show resolved Hide resolved

turtlebot3_fake_node/src/turtlebot3_fake_node.cpp Outdated Show resolved Hide resolved

Ryan Shim and others added 3 commits September 10, 2019 10:39

using nanosec for update_odom

4fa9c03

Merge branch 'ros2-devel' of github.com:ROBOTIS-GIT/turtlebot3_simula…

cee5c34

…tions into ros2-devel

Modified CI settings for ROS 2 Dashing patch 3

48c9ece

Signed-off-by: Pyo <pyo@robotis.com>

Ryan Shim added 2 commits September 16, 2019 14:00

now() function usage changed

ec9c4d6

Merge branch 'ros2-devel' of github.com:ROBOTIS-GIT/turtlebot3_simula…

372165b

…tions into ros2-devel

routiful approved these changes Sep 16, 2019

View reviewed changes

robotpilot approved these changes Sep 16, 2019

View reviewed changes

robotpilot merged commit 33d7470 into ros2 Sep 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added fake_node pkg, tb3_house #90

added fake_node pkg, tb3_house #90

JaehyunShim commented Sep 9, 2019

robotpilot commented Sep 9, 2019

routiful left a comment

routiful commented Sep 9, 2019 •

edited

Loading

JaehyunShim commented Sep 9, 2019

robotpilot Sep 9, 2019

robotpilot Sep 9, 2019

robotpilot Sep 9, 2019

robotpilot Sep 9, 2019

robotpilot Sep 9, 2019

robotpilot Sep 9, 2019

robotpilot Sep 9, 2019

robotpilot Sep 9, 2019

JaehyunShim commented Sep 9, 2019

robotpilot commented Sep 9, 2019

robotpilot left a comment

robotpilot commented Sep 11, 2019

routiful commented Sep 11, 2019

JaehyunShim commented Sep 11, 2019

robotpilot commented Sep 16, 2019

robotpilot commented Sep 16, 2019

routiful commented Sep 16, 2019

JaehyunShim commented Sep 16, 2019

robotpilot commented Sep 16, 2019

JaehyunShim commented Sep 16, 2019

		@@ -0,0 +1,39 @@
		# /*******************************************************************************

		@@ -0,0 +1,78 @@
		# /*******************************************************************************

added fake_node pkg, tb3_house #90

added fake_node pkg, tb3_house #90

Conversation

JaehyunShim commented Sep 9, 2019

robotpilot commented Sep 9, 2019

routiful left a comment

Choose a reason for hiding this comment

routiful commented Sep 9, 2019 • edited Loading

JaehyunShim commented Sep 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JaehyunShim commented Sep 9, 2019

robotpilot commented Sep 9, 2019

robotpilot left a comment

Choose a reason for hiding this comment

robotpilot commented Sep 11, 2019

routiful commented Sep 11, 2019

JaehyunShim commented Sep 11, 2019

robotpilot commented Sep 16, 2019

Build Status

robotpilot commented Sep 16, 2019

routiful commented Sep 16, 2019

JaehyunShim commented Sep 16, 2019

robotpilot commented Sep 16, 2019

JaehyunShim commented Sep 16, 2019

routiful commented Sep 9, 2019 •

edited

Loading