Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flang][OpenMP] Handle expressions in
target ... do
loop control #107[flang][OpenMP] Handle expressions in
target ... do
loop control #107Changes from all commits
55235b9
6fc5b8b
c31551c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm wondering: Is everything from here to the end of the function needed still? It seems like your additions may potentially be already handling all cases. You can try commenting it out and running check-flang and smoke-fort tests and see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything from this point below is still needed. What I added perpares for the following logic to work properly in case a target region argument is used indirectly outside the region. What I added above does not remap the target region arguments.
This is verifiable even using the lit test I added below. If you comment out the logic you previously added, you will find that now we clone the slice of operations needed by the trip count calculation but at the root of this slice, a use of the target region argument is still there.