Skip to content

Commit

Permalink
Avoid dev package recommends/suggestion for ASAN (#234)
Browse files Browse the repository at this point in the history
* Avoid dev package recommends/suggestion for ASAN

* Updated Review Comments

* Fix for Lint errors - simplified if loop
  • Loading branch information
arvindcheru authored Oct 24, 2024
1 parent 8c9ef65 commit 67ae770
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions share/rocmcmakebuildtools/cmake/ROCMCreatePackage.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,16 @@ macro(rocm_create_package)
if (ROCM_USE_DEV_COMPONENT)
rocm_compute_component_package_name(devel "${CPACK_PACKAGE_NAME}" "${PARSE_SUFFIX}" "${PARSE_HEADER_ONLY}")
list(APPEND PARSE_COMPONENTS devel)
rocm_join_if_set(", " CPACK_DEBIAN_RUNTIME_PACKAGE_RECOMMENDS
"${CPACK_DEBIAN_DEVEL_PACKAGE_NAME} (>=${CPACK_PACKAGE_VERSION})")
if (NOT ENABLE_ASAN_PACKAGING)
# Since no asan-dev package available, avoid recommends for ASAN
rocm_join_if_set(", " CPACK_DEBIAN_RUNTIME_PACKAGE_RECOMMENDS
"${CPACK_DEBIAN_DEVEL_PACKAGE_NAME} (>=${CPACK_PACKAGE_VERSION})"
)
endif()

rocm_find_program_version(rpmbuild GREATER_EQUAL 4.12.0 QUIET)
if(rpmbuild_VERSION_OK)
if(rpmbuild_VERSION_OK AND NOT ENABLE_ASAN_PACKAGING)
# Since no asan-dev package available, avoid suggests for ASAN
rocm_join_if_set(", " CPACK_RPM_RUNTIME_PACKAGE_SUGGESTS
"${CPACK_RPM_DEVEL_PACKAGE_NAME} >= ${CPACK_PACKAGE_VERSION}"
)
Expand Down

0 comments on commit 67ae770

Please sign in to comment.