Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dev package recommends/suggestion for ASAN #234

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Avoid dev package recommends/suggestion for ASAN #234

merged 3 commits into from
Oct 24, 2024

Conversation

arvindcheru
Copy link
Contributor

@arvindcheru arvindcheru commented Oct 17, 2024 •
edited
Loading

Proposed Changes:

  • Since there are no -asan-dev available, Avoid suggests/recommends
  • Currently we are adding recommends for asan pkgs as an example for -asan we have
    Recommends: -asan-dev (>=2.21.5.60300) (but this package not exists)
  • Proposed change will remove this recommends/Suggests to unavailable -asan-dev package.

@arvindcheru arvindcheru marked this pull request as ready for review October 17, 2024 19:57
lawruble13
lawruble13 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@lawruble13 lawruble13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me, although it will need to be changed to pass the lint test.

@arvindcheru
Copy link
Contributor Author

Team, Kindly help to get this change merged.
It is still showing as "Merging is blocked"
Thanks!!

@lawruble13 lawruble13 merged commit 67ae770 into ROCm:develop Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnikri nunnikri nunnikri approved these changes

@lawruble13 lawruble13 lawruble13 approved these changes

@pfultz2 pfultz2 Awaiting requested review from pfultz2 pfultz2 is a code owner

@cgmb cgmb Awaiting requested review from cgmb cgmb is a code owner

@frepaul frepaul Awaiting requested review from frepaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvindcheru @lawruble13 @nunnikri