Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3] Fix for proto files not being viewable in Perfetto UI (#16) #19

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[6.3] Fix for proto files not being viewable in Perfetto UI (#16) #19

merged 1 commit into from
Dec 5, 2024

Conversation

dgaliffiAMD
Copy link
Collaborator

  • Fix for proto files not being viewable in Perfetto UI

  • Update Workflows

  • Use V47 trace_processor_shell for certain OS releases.

    • RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
    • Incompatible version of GLIBC.

  • Remove notes about Perfetto workaround in documentation.

@dgaliffiAMD dgaliffiAMD requested review from a team and jrmadsen as code owners November 6, 2024 15:37
@dgaliffiAMD
Copy link
Collaborator Author

Cherrypicking to release/rocm-rel-6.3

@dgaliffiAMD dgaliffiAMD force-pushed the 6.3/perfetto-fix branch 4 times, most recently from 4d68b2b to 4e2c15f Compare November 6, 2024 21:30
@dgaliffiAMD dgaliffiAMD requested a review from njobypet November 7, 2024 19:30
amd-jnovotny
amd-jnovotny approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes look good.

@dgaliffiAMD dgaliffiAMD changed the title Fix for proto files not being viewable in Perfetto UI (#16) [6.3] Fix for proto files not being viewable in Perfetto UI (#16) Nov 8, 2024
@dgaliffiAMD dgaliffiAMD mentioned this pull request Nov 14, 2024
Closed
@gsitaram
Copy link

@dgaliffiAMD , I have been pointed to this PR for a fix regarding merging multiple proto files into one. I wonder if this has to be merged to amd-staging, then to amd-mainline and then to rocm-release-6.3 branch. Please correct me if my understanding is wrong.

@dgaliffiAMD
Copy link
Collaborator Author

@dgaliffiAMD , I have been pointed to this PR for a fix regarding merging multiple proto files into one. I wonder if this has to be merged to amd-staging, then to amd-mainline, and then to rocm-release-6.3 branch. Please correct me if my understanding is wrong.

Hi @gsitaram, once a release branch has been created (branched from amd-mainline), it's pretty much in lock down mode. Individual changes can be cherry-picked and must be review by the @rocm/release-management team before they are approved and merged.
This change has been approved, but we have to wait for a @rocm/release-management member to merge it to release/rocm-rel-6.3.

@dgaliffiAMD dgaliffiAMD added the release promotion Tagged pull request is a candidate for cherry picking to a release branch label Nov 19, 2024
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (ROCm#16)
e88eb93 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@vamovsik vamovsik merged commit 6b848fb into ROCm:release/rocm-rel-6.3 Dec 5, 2024
37 checks passed
@dgaliffiAMD dgaliffiAMD deleted the 6.3/perfetto-fix branch December 13, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmadsen jrmadsen jrmadsen approved these changes

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@njobypet njobypet njobypet approved these changes

@ajanicijamd ajanicijamd Awaiting requested review from ajanicijamd

Assignees
No one assigned
Labels
release promotion Tagged pull request is a candidate for cherry picking to a release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dgaliffiAMD @gsitaram @jrmadsen @amd-jnovotny @njobypet @vamovsik