rework rccl BUILD rules to match more closely with upstream #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `nccl_config` - use `if_cuda_or_rocm` in place of `if_cuda`, not `if_nccl` - use `if_cuda`/`if_rocm`, not if_cuda/rocm_is_configured
whchung
reviewed
Jul 19, 2019
whchung
requested changes
Jul 19, 2019
whchung
reviewed
Jul 19, 2019
This partially reverts a whitespace change made by 471af21.
|
@whchung If the previous CI run completes, I would be okay with not needing the next commit's CI run since it was a whitespace change and I verified it locally. I'll leave it up to you. Depends how busy our CI is I suppose. |
whchung
approved these changes
Jul 19, 2019
jeffdaily
added a commit
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nccl_configif_cuda_or_rocmin place ofif_cuda, notif_ncclif_cuda/if_rocm, not if_cuda/rocm_is_configured