Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework rccl BUILD rules to match more closely with upstream #572

Merged
merged 2 commits into from
Jul 22, 2019
Merged

rework rccl BUILD rules to match more closely with upstream #572

merged 2 commits into from
Jul 22, 2019

Commits on Jul 19, 2019

  1. rework rccl BUILD rules to match more closely with upstream 

    - remove `nccl_config`
- use `if_cuda_or_rocm` in place of `if_cuda`, not `if_nccl`
- use `if_cuda`/`if_rocm`, not if_cuda/rocm_is_configured
    @jeffdaily
    jeffdaily committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    471af21 View commit details
    Browse the repository at this point in the history

  2. re-indent bazel load directive for rocm 

    This partially reverts a whitespace change made by
471af21.
    @jeffdaily
    jeffdaily committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    2244aee View commit details
    Browse the repository at this point in the history