Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--pointermap CSS does not permit whitespace #2348

Closed
kwvanderlinde opened this issue Dec 16, 2020 · 1 comment · Fixed by #3267
Closed

--pointermap CSS does not permit whitespace #2348

kwvanderlinde opened this issue Dec 16, 2020 · 1 comment · Fixed by #3267
Assignees
@kwvanderlinde
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@kwvanderlinde
Copy link
Collaborator

Describe the bug
When setting a value for the --pointermap custom CSS property, there cannot be any whitespace between the colon and the value (block, pass or blockopaque). This is inconsistent with regular CSS properties and is confusing.

To Reproduce
Steps to reproduce the behavior:

  1. Create a really simple overlay with a rectangular element: 
    [overlay("Test Overlay"): {
    <div style="width: 100px; height: 100px; background-color: black; --pointermap: block;"></div>
}]
  2. Click and drag, starting on overlay, then moving outside of the overlay. You should see the selection box as though --pointermap:pass were set.

Expected behavior
Whitespace is permitted around the property value. I.e., --pointermap: block should be functionally the same as --pointermap:block.

Screenshots
Just to make clear the results of my reproduction steps, this is what I see after the click-and-drag:
Screenshot from 2020-12-15 21-46-20 (trimmed)
The black rectangle is the <div> that has --pointermap: block set, and the blue rectangle is the selection box that proves that the value is not functioning as I expected.

MapTool Info

  • Version: 1.7.0
  • Install: New

Desktop (please complete the following information):

  • OS: Linux Mint
  • Version 10
kwvanderlinde added a commit to kwvanderlinde/maptool that referenced this issue Apr 28, 2021
@kwvanderlinde
Allow whitespace with --pointermap CSS
b639177 
Any leading or trailing whitespace is now removed from the value for the `--pointermap` CSS property. This allows it to
act more like a standard CSS property where leading and trailing whitespace is not significant, and it allows the CSS
author to format their code more freely.

Fixes RPTools#2348.
kwvanderlinde added a commit to kwvanderlinde/maptool that referenced this issue Dec 10, 2021
@kwvanderlinde
Allow whitespace with --pointermap CSS
6e22625 
Any leading or trailing whitespace is now removed from the value for the `--pointermap` CSS property. This allows it to
act more like a standard CSS property where leading and trailing whitespace is not significant, and it allows the CSS
author to format their code more freely.

Fixes RPTools#2348.
@kwvanderlinde kwvanderlinde mentioned this issue Dec 10, 2021
Merged
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Jul 9, 2022
@Phergus
Copy link
Contributor

Phergus commented Jul 9, 2022

Tested. This fix was actually in 1.11.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwvanderlinde kwvanderlinde

Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow whitespace with --pointermap CSS kwvanderlinde/maptool
2 participants
@kwvanderlinde @Phergus