Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow whitespace with --pointermap CSS #3267

Merged

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Dec 10, 2021

Identify the Bug or Feature request

Fixes #2348

Description of the Change

Any leading or trailing whitespace is now removed from the value for the --pointermap CSS property. This allows it to act more like a standard CSS property where leading and trailing whitespace is not significant, and it allows the CSS author to format their code more freely.

Possible Drawbacks

Anyone who has uses --pointermap: block but has forgotten about it and has gotten used to it's non-functional behaviour will get a fun surprise upon updating.

Documentation Notes

N/A

Release Notes

  • Fix custom CSS property --pointermap to allow leading and trailing whitespace in its value.

This change is Reviewable

Any leading or trailing whitespace is now removed from the value for the `--pointermap` CSS property. This allows it to
act more like a standard CSS property where leading and trailing whitespace is not significant, and it allows the CSS
author to format their code more freely.
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)

@Phergus Phergus merged commit 44fcb4a into RPTools:develop Dec 11, 2021
@kwvanderlinde kwvanderlinde deleted the issue-2348-pointermap-whitespace branch June 14, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--pointermap CSS does not permit whitespace
2 participants