Further environmental lighting performance improvements #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change is to unroll the loops, assigning each color component's result to a separate variable. This makes it clear to the JVM that the operations can be vectorized. On OpenJDK 17.0.1 there is minimal difference, but later versions would not vectorize without this change. `ConstrainedBrightenBlender` was also modified to use a simple conditional instead of a bit shift to decide between its two cases. The result is a consistent 30% shaved off render times.
cwisniew
approved these changes
May 11, 2023
kwvanderlinde
deleted the
performance/1.13-environmental-lights--improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Improves #4031
Description of the Change
The previous PR (#4042) introduced bit hacks that improved lighting performance specifically for OpenJDK 17.0.1 - 17.0.3. The current PR updates those changes so later versions are also happy to apply auto-vectorization. Also included is a cozy improvement to
ConstrainedBrightenBlenderthat applies for all JVM versions.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
N/A
This change is