Preallocate buffers for use with LightingComposite.BlenderContext #4073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Implements #4072
Description of the Change
Avoids allocating buffers in
LightingComposite.BlenderContext.compose()
as that method is called potentially many thousands of times per frame, especially with overlapping lights. The buffer size was chosen to hold 4096 pixels (16 KiB) in order to avoid chunked blending in most cases.Another improvement was reducing the number of buffers from 3 to 2 since we don't need a separate output buffer.
From a performance perspective, the same situation as in #4042 and #4054 went from typically looking like this
to
So roughly 30% shaved off lights rendering as a result.
Possible Drawbacks
32 KiB of unreclaimable memory, and a guilty conscience ...
Documentation Notes
N/A
Release Notes
This change is