Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Dockerfile in docker-library #7

Closed
m-dango opened this issue Feb 5, 2017 · 8 comments
Closed

Wrong Dockerfile in docker-library #7

m-dango opened this issue Feb 5, 2017 · 8 comments

Comments

@m-dango
Copy link
Contributor

m-dango commented Feb 5, 2017

docker pull still gets you 2016.11 as latest from the official repo:
https://github.com/docker-library/official-images/blob/master/library/rakudo-star

@hoelzro
Copy link
Contributor

hoelzro commented Feb 5, 2017

There's an outstanding pr to update the docker library with 2017.0: docker-library/official-images#2599

@m-dango
Copy link
Contributor Author

m-dango commented Feb 5, 2017

Ah I see. Maybe master or a tag could have a Dockerfile with rakudo_version=latest, with other branches/tags pointing to specific releases? (EDIT: This goes against their expectation of repeatability i.e "rebuilding the same Dockerfile should result in the same version of the image being packaged." Ignore me, I'm no Docker expert 🙂)

@JJ
Copy link
Contributor

JJ commented Feb 5, 2017 via email

@m-dango
Copy link
Contributor Author

m-dango commented Feb 6, 2017

I think we'll either need to give them a well defined use case for #6 or take it out, as we seem to be at a bit of an impasse with it.

@hoelzro
Copy link
Contributor

hoelzro commented Feb 6, 2017

Does anyone mind if I roll back #6 for now, just to get the new image built?

@hoelzro
Copy link
Contributor

hoelzro commented Feb 6, 2017

@JJ

@tianon
Copy link
Contributor

tianon commented Feb 6, 2017 via email

@hoelzro
Copy link
Contributor

hoelzro commented Feb 6, 2017

In the interest of getting the new image out there, I'm going to revert #6. We can always bring it back if needed.

hoelzro added a commit that referenced this issue Feb 6, 2017
This reverts commit 7724855, reversing
changes made to a7548f1.

Explanation:
    #7
    #6 (comment)
@m-dango m-dango closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants