Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation_JA_JP.json #1090

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Improve translation_JA_JP.json #1090

merged 1 commit into from
Sep 29, 2021

Conversation

yuk7
Copy link
Contributor

@yuk7 yuk7 commented Sep 29, 2021

  • Please check if the PR fulfills these requirements
  • [] The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?

Just improve translation

  • What is the current behavior?
  • What is the new behavior (if this is a feature change)?

  • Other information:

@Ralim Ralim merged commit 07ceb46 into Ralim:master Sep 29, 2021
@Ralim
Copy link
Owner

Ralim commented Sep 29, 2021

Thank you ❤️

Copy link
Contributor

@alvinhochun alvinhochun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and sorry for not commenting on this earlier. I appreciate your contributions, but please note that these changes break some displays.

By the way, the following items are deprecated and can be removed:

  • SettingsCalibrationDone
  • WarningTipTempString
  • BadTipString
  • WarningSimpleString
  • WarningAdvancedString
  • YourGainMessage

"InputVoltageString": "Input V: ",
"WarningTipTempString": "Tip temp: ",
"BadTipString": "BAD TIP",
"UVLOWarningString": "DC電圧が低すぎます",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning messages does not scroll so only 8 characters at maximum can be shown.

(I had thought of whether warning messages should be made scrolling instead, but non-CJK languages currently use small text in two rows instead of large text, so it's not as straightforward to change.)

Comment on lines +11 to +23
"UndervoltageString": "電圧不足",
"InputVoltageString": "入力電圧 V: ",
"WarningTipTempString": "コテ先温度: ",
"BadTipString": "コテ先エラー",
"SleepingSimpleString": "Zzzz",
"SleepingAdvancedString": "Sleeping...",
"WarningSimpleString": "HOT!",
"WarningAdvancedString": "!!! HOT TIP !!!",
"SleepingTipAdvancedString": "Tip:",
"IdleTipString": "Tip:",
"IdleSetString": " Set:",
"TipDisconnectedString": "NO TIP",
"SolderingAdvancedPowerPrompt": "Power: ",
"SleepingAdvancedString": "スリープ中...",
"WarningSimpleString": "高温注意!",
"WarningAdvancedString": "!!! コテ先高温 !!!",
"SleepingTipAdvancedString": "コテ先:",
"IdleTipString": "コテ先:",
"IdleSetString": " 設定:",
"TipDisconnectedString": "コテ先が接続されていません",
"SolderingAdvancedPowerPrompt": "電源: ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mind that most of strings are for the advanced standby/soldering screens and uses the small font, in which CJK cannot be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants