Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to controller-sdk 1.34.2 #1412

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ShyamsundarR
Copy link
Member

@ShyamsundarR ShyamsundarR commented May 20, 2024

The move to operator-sdk is to aid with newer APIs that we may define
and overall catching up to the later sdk versions for maintainability
of the code base in the future.

This commit has 2 major changes as follows,

  • Move controllers to internal/controller and main.go to cmd/

The above hence entails changes to Makefile, import paths, and other
artifacts that are path dependent.

  • Move to kustomize v5

The above changes patchesStrategicMerge to patches and commonLabels
to labels (though the latter is unused in comments)

Related to the actual change is to move the PROJECT file to
kubebuilder v4 and to update the install scripts to use the latest
versions of the required tools.

Overall changes were performed following the upgrade guides from v1.24.0
to v1.34.2:
https://sdk.operatorframework.io/docs/upgrading-sdk-version/

One of the bigger change to move from kubebuilder v3 to v4 required
following the migration guide at:
https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

Open areas:
Move to gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0
Change transformers to labels in kustomize

Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com

@nirs
Copy link
Member

nirs commented May 21, 2024

@ShyamsundarR do you think this will solve the issue with olm 0.27?

@ShyamsundarR
Copy link
Member Author

@ShyamsundarR do you think this will solve the issue with olm 0.27?

No :( This is so that newer APIs that we define, we can be on the latest operator-sdk and also on later dependencies as such (including kustomize).

@ShyamsundarR
Copy link
Member Author

@ShyamsundarR do you think this will solve the issue with olm 0.27?

No :( This is so that newer APIs that we define, we can be on the latest operator-sdk and also on later dependencies as such (including kustomize).

OR... let me check the delta again to see any olm related changes.

@ShyamsundarR
Copy link
Member Author

@ShyamsundarR do you think this will solve the issue with olm 0.27?

No :( This is so that newer APIs that we define, we can be on the latest operator-sdk and also on later dependencies as such (including kustomize).

OR... let me check the delta again to see any olm related changes.

There is/was nothing in the upgrade notes regarding the bundle as such, the operator-sdk version is changed and may help with the bundle+olm version issue that we have, but not certain.

@ShyamsundarR ShyamsundarR force-pushed the osdk-1-34-2 branch 2 times, most recently from 76000a6 to ca53ba5 Compare May 21, 2024 14:39
The move to operator-sdk is to aid with newer APIs that we may define
and overall catching up to the later sdk versions for maintainability
of the code base in the future.

This commit has 2 major changes as follows,
- Move controllers to internal/controller and main.go to cmd/

The above hence entails changes to Makefile, import paths, and other
artifacts that are path dependent.

- Move to kustomize v5

The above changes patchesStrategicMerge to patches and commonLabels
to labels (though the latter is unused in comments)

Related to the actual change is to move the PROJECT file to
kubebuilder v4 and to update the install scripts to use the latest
versions of the required tools.

Overall changes were performed following the upgrade guides from v1.24.0
to v1.34.2:
https://sdk.operatorframework.io/docs/upgrading-sdk-version/

One of the bigger change to move from kubebuilder v3 to v4 required
following the migration guide at:
https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

Open areas:
Move to gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0
Change transformers to labels in kustomize

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
@raghavendra-talur raghavendra-talur merged commit 1966369 into RamenDR:main Jul 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants