Bootstrap drclusterconfig #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShyamsundarR
force-pushed
the
bootstrap-drclusterconfig
branch
6 times, most recently
from
529bce3
to
7229837
Compare
Scaffolded using: operator_sdk create api Followed by, - make generate - make manifests Followed by, - corrections to generated code in main.go - additions of required CRDs and roles to the ramen dr-cluster bundle Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
The fields are as follows: spec.replicationSchedules: Is a list of schedule intervals that are required to be provided by the storage consumers of this resource. spec.clusterID Would carry the ManagedCluster identity from the ManagedCluster claim value for `id.k8s.io` spec.PeerClusters []clusterID is currently left as a TODO, to be picked up as the need arises. Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Also, adjust envtests to accomodate for one more manifest work creation and also as required marking the manifest work as applied. In addition to the above, reordered DRCluster processCreateOrUpdate in a manner that addresses processing fencing first and then later other checks, and maintenance mode last. This is to reflect DRCluster validation correctly, and perform certain checks early and some later. Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
As we need to update DRClusterConfig for the cluster if there are newer schedules added/removed. This requires reconciling DRCluster when a DRPolicy resource is created/updated/deleted. Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Also, add required client arguments, such that this can be reused across various envs and tests run in those envs. Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
With varying ManagedCluster resource status and conditions Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
ShyamsundarR
force-pushed
the
bootstrap-drclusterconfig
branch
from
7229837
to
423c0b1
Compare
rakeshgm
approved these changes
Jul 15, 2024
Added a more genric version of extracting a manifest from a ManifestWork to inspect its contents. Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
ShyamsundarR
force-pushed
the
bootstrap-drclusterconfig
branch
from
423c0b1
to
8bec09e
Compare
|
|
||
| // DRClusterConfig is the Schema for the drclusterconfigs API | ||
| // | ||
| //nolint:maligned |
There was a problem hiding this comment.
is this line required?
There was a problem hiding this comment.
As status is empty at present, the linter does not like the structure alignment. nolint added till there are elements in status, at which point this can be removed.
raghavendra-talur
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #1408
TODO: