Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocm-minikube-ramen.sh: volume-rep-class remove #166

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

hatfieldbrian
Copy link
Collaborator

Signed-off-by: bhatfiel bhatfiel@redhat.com

@hatfieldbrian
Copy link
Collaborator Author

This pull request should be merged after #121 is.

@ShyamsundarR
Copy link
Member

This would also need a change to the created VolRepClass to add a schedule as a parameter in there, that can match the DRPolicy set schedule. This enabled VRG to find the right Replication class to use.

@hatfieldbrian
Copy link
Collaborator Author

This pull request should be merged after #121 is.

Pull request #182 replaced #121 (see #121 (comment)) and has been merged.

	- minikube-rook-mirror-setup.sh: vrc-sample.spec.parameter add:
		schedulingInterval: 1m

Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
@hatfieldbrian
Copy link
Collaborator Author

This would also need a change to the created VolRepClass to add a schedule as a parameter in there, that can match the DRPolicy set schedule. This enabled VRG to find the right Replication class to use.

This has been addressed in the version of this pull request just pushed. Please review.

@ShyamsundarR ShyamsundarR merged commit 3f51e76 into RamenDR:main Aug 16, 2021
@hatfieldbrian hatfieldbrian deleted the volume-rep-class-delete branch August 16, 2021 19:27
ELENAGER pushed a commit to ELENAGER/ramen that referenced this pull request Jan 16, 2024
Bug 2247714: Enhancing Hub Recovery: Reworking DRPC State Rebuilding Algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants