use schedule instead of VolumeReplicationClass #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavendrabhat
force-pushed
the
main-drpc-schedule-replication-class-9
branch
5 times, most recently
from
1801080
to
fe2d571
Compare
ShyamsundarR
reviewed
Aug 6, 2021
ShyamsundarR
reviewed
Aug 6, 2021
| @@ -243,6 +244,18 @@ func (r *DRPlacementControlReconciler) reconcileDRPCInstance(ctx context.Context | |||
| return ctrl.Result{}, err | |||
| } | |||
|
|
|||
| // Currently validation of schedule in DRPolicy is done here. When | |||
There was a problem hiding this comment.
Ack! @hatfieldbrian tagging you here for consideration once this and the initial DRPolicy reconciler are merged.
hack/test/replication.storage.openshift.io_volumereplicationclasses.yaml
Show resolved
Hide resolved
| scName := pvc.Spec.StorageClassName | ||
|
|
||
| storageClass := &storagev1.StorageClass{} | ||
| if err := v.reconciler.Get(v.ctx, types.NamespacedName{Name: *scName}, storageClass); err != nil { |
There was a problem hiding this comment.
(nit) minor optimization possible here, as most often all PVCs would point to the same SC, so if we stash away the SCs we fetched, we can avoid fetching it again for the next PVC saving a call to the API server. (for later, just noting it for now)
raghavendrabhat
force-pushed
the
main-drpc-schedule-replication-class-9
branch
3 times, most recently
from
b0a9027
to
9e43d82
Compare
BenamarMk
reviewed
Aug 10, 2021
| } | ||
| } | ||
|
|
||
| if pvc == nil { |
There was a problem hiding this comment.
This statement should never be true. A possible fix would be to change line 1280 to:
var pvc *corev1.PersistentVolumeClaim
or change line 1293 to if *pvc == (corev1.PersistentVolumeClaim{}) {
raghavendrabhat
force-pushed
the
main-drpc-schedule-replication-class-9
branch
from
9e43d82
to
46cd07e
Compare
VolumeReplicationClass field in VolumeReplicationGroup is
nothing but a string. Instead of that, use a schedule which
is then used in combination with the storage driver for the
pvc (obtained from storageclass) by the VolumeReplicationGroup
to determine the appropriate VolumeReplicationClass to use.
HUB/DRPC (Previously AVR):
- modify DRPolicy to include schedule along with DR prepared
clusters
- Make DRPC (previously AVR) refer to the DRPolicy schedule
while creating VolumeReplicationGroup and use that as the
schedule for VolumeReplicationGroup.
Managed Cluster:
- While reconciling VolumeReplicationGroup, for each of the
PVC obtained via label selection, do this
- storagedriver = StorageDriver(StorageClass(pvc))
- Get All the VolumeReplicationClasses in the cluster
- For each VolumeReplicationClass (chosen via label selector)
if (replicationdriver == storagedriver and
replicationSchedule == vrg.Spec.Schedule)
chosenReplicationClass = VolumeReplicationClass
Signed-off-by: Raghavendra M <raghavendra@redhat.com>
raghavendrabhat
force-pushed
the
main-drpc-schedule-replication-class-9
branch
from
46cd07e
to
0aa1fc0
Compare
ShyamsundarR
approved these changes
Aug 11, 2021
BenamarMk
approved these changes
Aug 11, 2021
rakeshgm
pushed a commit
to rakeshgm/ramen
that referenced
this pull request
Apr 5, 2024
Syncing latest changes from upstream main for ramen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VolumeReplicationClass field in VolumeReplicationGroup is
nothing but a string. Instead of that, use a schedule which
is then used in combination with the storage driver for the
pvc (obtained from storageclass) by the VolumeReplicationGroup
to determine the appropriate VolumeReplicationClass to use.
HUB/DRPC (Previously AVR):
clusters
while creating VolumeReplicationGroup and use that as the
schedule for VolumeReplicationGroup.
Managed Cluster:
PVC obtained via label selection, do this
if (replicationdriver == storagedriver and
replicationSchedule == vrg.Spec.Schedule)
chosenReplicationClass = VolumeReplicationClass
Signed-off-by: Raghavendra M raghavendra@redhat.com