Fix mesh mutation frequency #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: geodesic distance calculations relative to user defined vertices * ci: remove macos * build: Update geometry central version * build: do not search for netcdf --------- Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Due to variable time stepping algorithms the time step can vary with system configuration. The modified time step was used for updating mutation/prescription counters leading to difficult to predict behavior. Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
…ssing when fixed boundary conditions are used !Modifies split/collapse behavior for fixed boundary simulations Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
…istency check issues Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
suikarum1
reviewed
Dec 7, 2024
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
…llapse Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
This reverts commit 76dcb5b.
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
ctlee
added a commit
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mesh mutation and property prescription algorithms are set as a function of numbers of time steps. Variable time step setting algorithms change the simulation time step as a function of the stiffness of the configuration. Since the next update times were set as a function of the current time step it led to irregular frequencies of update.
This PR adds a baseTimeStep which keeps track of the user intended step relative to which the mutation/prescription periods should be set.
Todos
Status