Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with entity values #106

Closed
ghost opened this issue Jan 16, 2017 · 2 comments
Closed

Issue with entity values #106

ghost opened this issue Jan 16, 2017 · 2 comments
Assignees
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@ghost
Copy link

ghost commented Jan 16, 2017

Hi,

I am trying to map synonyms and misspellings to predefined values (using spacy + sklearn). In demo-rasa.json, I add the following (plus several other possibilities):
{
"text": "show me tchineez restaurants",
"intent": ""restaurant_search"",
"entities": [
{
"start": 8,
"end": 16,
"value": ""chinese"",
"entity": "cuisine"
}
]
}
After training, when I send "show me tchineez restaurants" to parse, I get "tchineez" as the entity value instead of the "chinese".

@amn41
Copy link
Contributor

amn41 commented Jan 16, 2017

Indeed this isn't currently implemented. See entity normalization here in the roadmap.

The simplest way to do this would just be to create a list of aliases in your code & reconcile them later. Support for doing this natively (& more generally) is coming, but I can't tell you exactly when.

@amn41 amn41 added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Jan 16, 2017
@amn41
Copy link
Contributor

amn41 commented Feb 6, 2017

My suggestion for how to implement this is to build up a map when we read through the training data. All entities are then mapped by their "value". So the map would look like :

{ 
  "tchineez" : "chinese",
  "chinese" : "chinese",
  "china" : "chinese"
  ...etc
}

built up from entities like

{  
   "text":"show me tchineez restaurants",
   "intent":""   restaurant_search"",
   "entities":[  
      {  
         "start":8,
         "end":16,
         "value":"chinese",
         "entity":"cuisine"
      }
   ]
}

We would persist this in the model dir, as index.json or something

@plauto plauto mentioned this issue Feb 12, 2017
@tmbo tmbo closed this as completed Feb 28, 2017
varunshankar pushed a commit that referenced this issue Nov 29, 2023
varunshankar added a commit that referenced this issue Nov 30, 2023
…9] (#12965)

* Merge pull request #106 from RasaHQ/ENG-680-DEFAULT_KEEP_ALIVE_TIMEOUT

Fix connection to action server - [ENG 680]

---------

Co-authored-by: Tom Bocklisch <tom@rasa.com>
vcidst pushed a commit that referenced this issue Jan 23, 2024
Fix connection to action server - [ENG 680]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

3 participants