Port "connection timeout to action server" changes to 3.6.x - [ENG 689] #12965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix connection to action server - [ENG 680]
varunshankar
changed the title
varunshankar
requested review from
tmbo,
twerkmeister,
tabergma and
OgnjenFrancuski
tabergma
approved these changes
Nov 30, 2023
OgnjenFrancuski
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Same as @tabergma, I'm not familiar with the code itself, even if I'm familiar with the error 😄
Tests are passing, so everything should be good!
|
@tabergma @OgnjenFrancuski Thank you for the approval :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
3.6.xStatus (please check what you already did):
black(please check Readme for instructions)