Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on tensorflow-addons #12514

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Remove dependency on tensorflow-addons #12514

merged 9 commits into from
Jun 19, 2023

Conversation

d61h6k4
Copy link
Contributor

@d61h6k4 d61h6k4 commented Jun 16, 2023

Proposed changes:
tensorflow-addons is deprecated. Read here for more.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@d61h6k4 d61h6k4 requested a review from a team as a code owner June 16, 2023 08:21
@m-vdb m-vdb requested a review from twerkmeister June 16, 2023 08:28
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to discuss if we shouldn't target 3.6.x. I'll raise this to Rosana

rasa/utils/tensorflow/crf.py Outdated Show resolved Hide resolved
@m-vdb m-vdb removed the request for review from twerkmeister June 16, 2023 08:47
@m-vdb m-vdb requested a review from twerkmeister June 19, 2023 10:07
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with one suggestion

Comment on lines 7 to 9
# original code taken from
# https://github.com/tensorflow/addons/blob/master/tensorflow_addons/metrics/f_scores.py
# (modified to our neeeds)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be more specific with the reference that we have taken the code parts from, e.g. using a tag or commit hash? If we ever need to check what we changed ourselves, that would be useful. Same for all the copies.

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12514--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@d61h6k4 d61h6k4 merged commit 59639bb into main Jun 19, 2023
@d61h6k4 d61h6k4 deleted the ENG-284-docker-arm branch June 19, 2023 13:37
d61h6k4 pushed a commit that referenced this pull request Jun 20, 2023
Remove dependency on tensorflow-addons

Copy tests for crf and metrics
d61h6k4 pushed a commit that referenced this pull request Jun 23, 2023
* Bump version of tensorflow (#12515)

Bump version of tensorflow

* Fix spacy version, bump the pydantic version because of explosion/spaCy#12659
* Fix ruff version because of new warnings
* Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py
* Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises

* Remove dependency on tensorflow-addons (#12514)

Remove dependency on tensorflow-addons

Copy tests for crf and metrics

* Multi-platform image with GitHub Actions (#12528)

* Build both platforms on the same machine

* Bump version of tensorflow (#12515)

Bump version of tensorflow

* Fix spacy version, bump the pydantic version because of explosion/spaCy#12659
* Fix ruff version because of new warnings
* Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py
* Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises

* Remove dependency on tensorflow-addons (#12514)

Remove dependency on tensorflow-addons

Copy tests for crf and metrics

* Multi-platform image with GitHub Actions (#12528)

* Build both platforms on the same machine

* Update poetry

* Add changelog

---------

Co-authored-by: Sanchari <s.ghosh@rasa.com>
souvikg10 pushed a commit that referenced this pull request Jun 26, 2023
Remove dependency on tensorflow-addons

Copy tests for crf and metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants