-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on tensorflow-addons #12514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to discuss if we shouldn't target 3.6.x
. I'll raise this to Rosana
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with one suggestion
rasa/utils/tensorflow/metrics.py
Outdated
# original code taken from | ||
# https://github.com/tensorflow/addons/blob/master/tensorflow_addons/metrics/f_scores.py | ||
# (modified to our neeeds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more specific with the reference that we have taken the code parts from, e.g. using a tag or commit hash? If we ever need to check what we changed ourselves, that would be useful. Same for all the copies.
🚀 A preview of the docs have been deployed at the following URL: https://12514--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Remove dependency on tensorflow-addons Copy tests for crf and metrics
* Bump version of tensorflow (#12515) Bump version of tensorflow * Fix spacy version, bump the pydantic version because of explosion/spaCy#12659 * Fix ruff version because of new warnings * Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py * Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises * Remove dependency on tensorflow-addons (#12514) Remove dependency on tensorflow-addons Copy tests for crf and metrics * Multi-platform image with GitHub Actions (#12528) * Build both platforms on the same machine * Bump version of tensorflow (#12515) Bump version of tensorflow * Fix spacy version, bump the pydantic version because of explosion/spaCy#12659 * Fix ruff version because of new warnings * Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py * Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises * Remove dependency on tensorflow-addons (#12514) Remove dependency on tensorflow-addons Copy tests for crf and metrics * Multi-platform image with GitHub Actions (#12528) * Build both platforms on the same machine * Update poetry * Add changelog --------- Co-authored-by: Sanchari <s.ghosh@rasa.com>
Remove dependency on tensorflow-addons Copy tests for crf and metrics
Proposed changes:
tensorflow-addons
is deprecated. Read here for more.Status (please check what you already did):
black
(please check Readme for instructions)