Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-platform image with GitHub Actions #12528

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Multi-platform image with GitHub Actions #12528

merged 4 commits into from
Jun 20, 2023

Conversation

d61h6k4
Copy link
Contributor

@d61h6k4 d61h6k4 commented Jun 19, 2023

Proposed changes:
Build both platforms on the same machine

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@d61h6k4 d61h6k4 requested a review from a team as a code owner June 19, 2023 15:43
@d61h6k4 d61h6k4 requested review from rasa-jmac and removed request for a team June 19, 2023 15:43
@d61h6k4 d61h6k4 requested a review from tmbo June 19, 2023 16:13
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍

I read up on some multi arch docs, checked docker hub for danil's test run of the build and that a build on main won't affect the latest tag

@d61h6k4 d61h6k4 merged commit f9682d4 into main Jun 20, 2023
70 checks passed
@d61h6k4 d61h6k4 deleted the cidockerbuild branch June 20, 2023 08:50
d61h6k4 pushed a commit that referenced this pull request Jun 20, 2023
* Build both platforms on the same machine
d61h6k4 pushed a commit that referenced this pull request Jun 23, 2023
* Bump version of tensorflow (#12515)

Bump version of tensorflow

* Fix spacy version, bump the pydantic version because of explosion/spaCy#12659
* Fix ruff version because of new warnings
* Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py
* Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises

* Remove dependency on tensorflow-addons (#12514)

Remove dependency on tensorflow-addons

Copy tests for crf and metrics

* Multi-platform image with GitHub Actions (#12528)

* Build both platforms on the same machine

* Bump version of tensorflow (#12515)

Bump version of tensorflow

* Fix spacy version, bump the pydantic version because of explosion/spaCy#12659
* Fix ruff version because of new warnings
* Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py
* Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises

* Remove dependency on tensorflow-addons (#12514)

Remove dependency on tensorflow-addons

Copy tests for crf and metrics

* Multi-platform image with GitHub Actions (#12528)

* Build both platforms on the same machine

* Update poetry

* Add changelog

---------

Co-authored-by: Sanchari <s.ghosh@rasa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants