-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use output_channel of externally triggered intent as input_channel #6272
Conversation
Thanks for submitting a pull request 🚀 @b-quachtran will take a look at it as soon as possible ✨ |
@federicotdn It looks good to me, thoughts? |
It's a bit strange to be using an output channel to populate the latest input channel field of the tracker, given that they are not the same thing. Maybe we could update the tracker in a way where the latest input channel property is not lost? Maye @JEM-Mosig has an opinion on this. |
@federicotdn, @b-quachtran, I could make |
Ah, I see this was cloned at #6472. |
I think that makes a lot of sense, given the name of the method |
Yeah, I'll close this PR in favor of #6472 then. |
Proposed changes:
/conversations/<conversation_id>/trigger_intent
results in a user event with input channelNone
. This meanslatest
output channel is effectively lost until a "real" user message comes in from a channel. This sets input channel using the output channel determined from the request.Status (please check what you already did):
black
(please check Readme for instructions)