Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep latest_input_channel when triggering intents #6472

Merged
merged 9 commits into from
Sep 8, 2020

Conversation

federicotdn
Copy link
Contributor

Proposed changes:
When using the POST .../trigger_intent endpoint, or the ReminderScheduled event, the tracker's latest input channel property is set to None. This PR changes this so that the property is not modified.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. can you please add a test?

@federicotdn federicotdn merged commit 8ea4169 into master Sep 8, 2020
@federicotdn federicotdn deleted the trigger-intent-channel branch September 8, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants