Allow Asset Tx Chaining #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 16, 2018 16:11
submitting tx twice
cfox
reviewed
Aug 20, 2018
|
|
||
| if (mapAssetsAddressAmount[make_pair(assetName, address)] == 0 && | ||
| if (mapAssetsAddressAmount.at(pair) < 0) |
There was a problem hiding this comment.
This should never happen right?
There was a problem hiding this comment.
Can happen, only with chained transactions. It occurs when blocks are being undone because of a chain split
| if (!totalInputs.count(outValue.first)) { | ||
| std::string errorMsg; | ||
| errorMsg = strprintf("Bad Transaction - Trying to create outpoint for asset that you don't have: %s", outValue.first); | ||
| return state.DoS(100, false, REJECT_INVALID, "bad-tx-inputs-outputs-mismatch " + errorMsg); |
There was a problem hiding this comment.
The return statements are the same yes, but they return different messages.
src/wallet/wallet.cpp
Outdated
| const CAmount &nMaximumAmount, const CAmount &nMinimumSumAmount, | ||
| const uint64_t &nMaximumCount, const int &nMinDepth, const int &nMaxDepth) const | ||
| { | ||
| if (!AreAssetsDeployed()) |
There was a problem hiding this comment.
Should this still return RVN coins instead of bailing?
There was a problem hiding this comment.
Updated with better code. This is a copy paste mistake
src/wallet/wallet.cpp
Outdated
| } | ||
|
|
||
|
|
||
| // setCoinsRet.insert(CInputCoin(out.tx, out.i)); |
There was a problem hiding this comment.
commented section still needed?
There was a problem hiding this comment.
Removed the commented out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the following to be done with assets before a block is mined.
issue CHAIN 100 , issue CHAIN/A 100, issue CHAIN/B 100issue CHAIN/A/A ,issue CHAIN/A/A/CYou can also chain reissues of a asset once it is issued in a block
Block Mined that contains the above issues
reissue CHAIN 100 "address", reissue CHAIN 200 "address"two or more reissues are valid to the chainEnforce all asset transaction OutPoints to contain 0 RVN in them. This will make it so the network wont allow tx's to accidentally spend there assets when spending RVN to an address.
Updated AvailableCoins function to return only asset tx's or rvn tx's depending on flags passed to function. This fixes the asset outpoints showing up in the Send Dialog Coincontrol. Only RVN tx's show up in the Send Dialog Coincontrol box.