Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Duolingo - Unlock Super): Correct instruction offset #3023

Merged
merged 1 commit into from
Sep 24, 2023
Merged

fix(Duolingo - Unlock Super): Correct instruction offset #3023

merged 1 commit into from
Sep 24, 2023

Conversation

Elassyo
Copy link

@Elassyo Elassyo commented Sep 24, 2023

This PR fixes ReVanced/revanced-patches#2892 and #374.
No integration.

The offset used to replace instructions was incorrect because of the filters.

Disclaimer: I'm a Kotlin noob so this might not be the best or cleanest solution.

@oSumAtrIX oSumAtrIX changed the title fix(Duolingo/Unlock Super): correct instruction offset fix(Duolingo - Unlock Super): Correct instruction offset Sep 24, 2023
@oSumAtrIX oSumAtrIX merged commit 5146de8 into ReVanced:dev Sep 24, 2023
@welcome
Copy link

welcome bot commented Sep 24, 2023

Thank you for contributing to ReVanced. Join us on Discord if you want to receive a contributor role.

revanced-bot pushed a commit that referenced this pull request Sep 24, 2023
# [2.191.0-dev.7](ReVanced/revanced-patches@v2.191.0-dev.6...v2.191.0-dev.7) (2023-09-24)

### Bug Fixes

* **Duolingo - Unlock Super:** Get correct instruction offset ([#3023](ReVanced/revanced-patches#3023)) ([5146de8](ReVanced/revanced-patches@5146de8))
revanced-bot pushed a commit that referenced this pull request Oct 4, 2023
# [2.191.0](ReVanced/revanced-patches@v2.190.0...v2.191.0) (2023-10-04)

### Bug Fixes

* Add hooks to existing hook set ([5655067](ReVanced/revanced-patches@5655067))
* **Duolingo - Unlock Super:** Get correct instruction offset ([#3023](ReVanced/revanced-patches#3023)) ([5146de8](ReVanced/revanced-patches@5146de8))
* **Google Recorder - Remove device restrictions:** Clarify limitation ([094f57b](ReVanced/revanced-patches@094f57b))
* **Infinity for Reddit - Spoof client:** Constrain patch to last working versions ([#2944](ReVanced/revanced-patches#2944)) ([ee975de](ReVanced/revanced-patches@ee975de))
* **Relay - Spoof client:** Restore OAuth login ([96e01f7](ReVanced/revanced-patches@96e01f7))
* **Slide - Spoof client:** Use correct patch name ([f355dbf](ReVanced/revanced-patches@f355dbf))
* **Sync for Reddit:** Do not throw an error when not necessary ([ef644e4](ReVanced/revanced-patches@ef644e4))
* **TikTok - Hide ads:** Constrain to last working version ([56e45a6](ReVanced/revanced-patches@56e45a6))
* **Twitch - Audio ads:** Support missing version `16.1.0` ([#2928](ReVanced/revanced-patches#2928)) ([688d8fa](ReVanced/revanced-patches@688d8fa))
* Use consistent toggle description ([#2983](ReVanced/revanced-patches#2983)) ([ceaa512](ReVanced/revanced-patches@ceaa512))
* Use correct instruction ([246cf2c](ReVanced/revanced-patches@246cf2c))
* **YouTube - Client spoof:** adjust settings text ([#3035](ReVanced/revanced-patches#3035)) ([59a2e96](ReVanced/revanced-patches@59a2e96))
* **YouTube - Client spoof:** Display seekbar thumbnails in high quality ([5e8a2d3](ReVanced/revanced-patches@5e8a2d3))
* **YouTube - Client spoof:** Do not record feed videos to history by default ([#3017](ReVanced/revanced-patches#3017)) ([5ccbf1b](ReVanced/revanced-patches@5ccbf1b))
* **YouTube - Client spoof:** Removed unused code ([#3030](ReVanced/revanced-patches#3030)) ([15e27bf](ReVanced/revanced-patches@15e27bf))
* **YouTube - Client spoof:** Restore seekbar thumbnails ([bf4a115](ReVanced/revanced-patches@bf4a115))
* **YouTube - Client spoof:** Show seekbar thumbnail for age restricted and paid videos ([1a79300](ReVanced/revanced-patches@1a79300))
* **YouTube - Custom filter:** Use new lines between components instead of commas ([#2952](ReVanced/revanced-patches#2952)) ([ecb2e32](ReVanced/revanced-patches@ecb2e32))
* **YouTube - Hide "Load more" button:** Use correct names ([569c3cd](ReVanced/revanced-patches@569c3cd))
* **YouTube - Hide info cards:** Fix info cards not hiding for some users ([#3039](ReVanced/revanced-patches#3039)) ([cb38637](ReVanced/revanced-patches@cb38637))
* **YouTube - Hide layout components:** Always hide redundant 'player audio track' button ([#2951](ReVanced/revanced-patches#2951)) ([ca632bd](ReVanced/revanced-patches@ca632bd))
* **YouTube - Hide shorts components:** Fix hiding navigation bar ([2de51e6](ReVanced/revanced-patches@2de51e6))
* **YouTube - Premium heading:** Correct inverted logic ([#3042](ReVanced/revanced-patches#3042)) ([b33ed75](ReVanced/revanced-patches@b33ed75))
* **YouTube - ReturnYouTubeDislike:** Revert support for 18.37.36 ([#3041](ReVanced/revanced-patches#3041)) ([3761073](ReVanced/revanced-patches@3761073))
* **YouTube - SponsorBlock:** Adjust import/export UI text ([#3063](ReVanced/revanced-patches#3063)) ([4e5513e](ReVanced/revanced-patches@4e5513e))
* **YouTube - Video Id:** Fix video id not showing the currently playing video ([#3038](ReVanced/revanced-patches#3038)) ([f6f226b](ReVanced/revanced-patches@f6f226b))
* **YouTube:** Restore functionality of `Old video quality menu` and `Custom speeds` on tablets ([#2999](ReVanced/revanced-patches#2999)) ([238bed1](ReVanced/revanced-patches@238bed1))

### Features

* Add notice for thumbnails for age restricted or paid videos ([f7cf70b](ReVanced/revanced-patches@f7cf70b))
* **Duolingo:** Remove `Unlock Duolingo Super` patch ([b4b9746](ReVanced/revanced-patches@b4b9746))
* **SPB Serviceportal Bund:** Add `Remove root detection` patch ([#3049](ReVanced/revanced-patches#3049)) ([481bf58](ReVanced/revanced-patches@481bf58))
* **Strava:** Add `Disable subscription suggestions` patch ([#2997](ReVanced/revanced-patches#2997)) ([af02175](ReVanced/revanced-patches@af02175))
* **Sync for Reddit - Client spoof:** Restore upload functionality ([9344c8a](ReVanced/revanced-patches@9344c8a))
* **TikTok - Hide ads:** Constrain to last working version ([516e8a1](ReVanced/revanced-patches@516e8a1))
* **TU Dortmund:** Add `Show on lockscreen` patch ([#2947](ReVanced/revanced-patches#2947)) ([9a18326](ReVanced/revanced-patches@9a18326))
* **Tumblr:** Add `Disable blog notification reminder` patch ([29f19b9](ReVanced/revanced-patches@29f19b9))
* **Tumblr:** Add `Disable dashboard ads` patch ([#2979](ReVanced/revanced-patches#2979)) ([07c267a](ReVanced/revanced-patches@07c267a))
* **Tumblr:** Add `Disable gift message popup` patch ([a4d6b4e](ReVanced/revanced-patches@a4d6b4e))
* **Tumblr:** Add `Disable in-app update` patch ([#3058](ReVanced/revanced-patches#3058)) ([5e8076b](ReVanced/revanced-patches@5e8076b))
* **Tumblr:** Add `Disable Tumblr Live` patch ([#2987](ReVanced/revanced-patches#2987)) ([bf1f9dc](ReVanced/revanced-patches@bf1f9dc))
* **Twitch - Block embedded ads:** Switch from `ttv.lol` to `luminous.dev` ([0fe115e](ReVanced/revanced-patches@0fe115e))
* Use properties file for `Client spoof` patches ([e5d548c](ReVanced/revanced-patches@e5d548c))
* **YouTube - Hide layout components:** Hide "Join" button ([1b71f89](ReVanced/revanced-patches@1b71f89))
* **YouTube - Hide layout components:** Hide "Notify me" button ([3027c15](ReVanced/revanced-patches@3027c15))
* **YouTube - Hide layout components:** Hide search result shelf header ([f4eda8c](ReVanced/revanced-patches@f4eda8c))
* **YouTube - Hide layout components:** Hide timed reactions ([d0a775d](ReVanced/revanced-patches@d0a775d))
* **YouTube - Premium heading:** Allow using default heading ([#3029](ReVanced/revanced-patches#3029)) ([d5ab35a](ReVanced/revanced-patches@d5ab35a))
* **YouTube - Spoof app version:** add version 18.20.39 ([#3001](ReVanced/revanced-patches#3001)) ([f14c5e7](ReVanced/revanced-patches@f14c5e7))
* **YouTube:** Add `Bypass URL redirects` patch ([125cac5](ReVanced/revanced-patches@125cac5))
* **YouTube:** Bump compatibility to `18.37.36` ([#3028](ReVanced/revanced-patches#3028)) ([eda28e5](ReVanced/revanced-patches@eda28e5))
@Elassyo Elassyo deleted the fix-duolingo-unlock-super branch October 8, 2023 16:33
validcube pushed a commit to validcube/revanced-patches that referenced this pull request Aug 6, 2024
validcube pushed a commit to validcube/revanced-patches that referenced this pull request Aug 6, 2024
# [4.7.0-dev.10](ReVanced/revanced-patches@v4.7.0-dev.9...v4.7.0-dev.10) (2024-04-17)

### Features

* **YouTube:** Add 'About' preference to settings menu ([#2981](ReVanced/revanced-patches#2981)) ([5abf894](ReVanced/revanced-patches@5abf894))
* **YouTube:** Match overlay icons style to YouTube ([ReVanced#3023](ReVanced/revanced-patches#3023)) ([6849393](ReVanced/revanced-patches@6849393))
validcube pushed a commit to validcube/revanced-patches that referenced this pull request Aug 6, 2024
# [4.7.0](ReVanced/revanced-patches@v4.6.0...v4.7.0) (2024-04-21)

### Bug Fixes

* **Tumblr - Fix old versions:** Improve reliability by removing remnances of Tumblr Live  ([#2988](ReVanced/revanced-patches#2988)) ([897b4db](ReVanced/revanced-patches@897b4db))
* **YouTube - GmsCore support:** Prompt to disable battery optimizations, if not done already ([#2958](ReVanced/revanced-patches#2958)) ([82acb84](ReVanced/revanced-patches@82acb84))
* **YouTube - Hide ads:** rename `Hide paid content` to `Hide paid promotion label` ([#3026](ReVanced/revanced-patches#3026)) ([17e4ac9](ReVanced/revanced-patches@17e4ac9))
* **YouTube - Hide load more button:** Include patch with `Hide layout components`, and hide button only in search feed  ([#2959](ReVanced/revanced-patches#2959)) ([b007e8e](ReVanced/revanced-patches@b007e8e))
* **YouTube - Hide Shorts components:** Correctly hide Shorts if navigation tab is changed using device back button ([#3007](ReVanced/revanced-patches#3007)) ([e5848e9](ReVanced/revanced-patches@e5848e9))
* **YouTube - Player flyout menu:** Add hide Lock screen menu ([#2985](ReVanced/revanced-patches#2985)) ([308de4a](ReVanced/revanced-patches@308de4a))
* **YouTube - Spoof device dimensions:** Warn about potential performance issues ([ReVanced#3039](ReVanced/revanced-patches#3039)) ([9d6f305](ReVanced/revanced-patches@9d6f305))
* **YouTube Music - Remove upgrade button:** Fix compatibility with latest versions ([#3045](ReVanced/revanced-patches#3045)) ([80de996](ReVanced/revanced-patches@80de996))

### Features

* Add `Hex` patch ([#3034](ReVanced/revanced-patches#3034)) ([3c95aac](ReVanced/revanced-patches@3c95aac))
* **Amazon:** Add `Always allow deep-linking` patch ([#3000](ReVanced/revanced-patches#3000)) ([a92b7fb](ReVanced/revanced-patches@a92b7fb))
* **Strava - Unlock subscription:** Remove compatible version constraint ([80a5599](ReVanced/revanced-patches@80a5599))
* **Twitter:** Add `Sanitize sharing links` patch ([#3003](ReVanced/revanced-patches#3003)) ([186b887](ReVanced/revanced-patches@186b887))
* **YouTube - Hide layout components:** Add option to hide horizontal shelves ([ReVanced#2951](ReVanced/revanced-patches#2951)) ([9ae0650](ReVanced/revanced-patches@9ae0650))
* **YouTube - Hide layout components:** Hide playables ([8423515](ReVanced/revanced-patches@8423515))
* **YouTube - Hide Shorts components:** Hide `Shop`, `Location` and `Save sound to playlist` buttons ([ReVanced#3018](ReVanced/revanced-patches#3018)) ([5210ac4](ReVanced/revanced-patches@5210ac4))
* **YouTube - Hide Shorts components:** Hide tagged products, hide search suggestions ([#3019](ReVanced/revanced-patches#3019)) ([e0d2fe5](ReVanced/revanced-patches@e0d2fe5))
* **YouTube - Swipe controls:** Save and restore brightness and add auto-brightness toggle ([#2996](ReVanced/revanced-patches#2996)) ([f6c3bc4](ReVanced/revanced-patches@f6c3bc4))
* **YouTube:** Add 'About' preference to settings menu ([#2981](ReVanced/revanced-patches#2981)) ([5abf894](ReVanced/revanced-patches@5abf894))
* **YouTube:** Match overlay icons style to YouTube ([ReVanced#3023](ReVanced/revanced-patches#3023)) ([6849393](ReVanced/revanced-patches@6849393))
* **YouTube:** Support version `19.09.38`, `19.10.39` and `19.11.43` ([#2971](ReVanced/revanced-patches#2971)) ([730f3e3](ReVanced/revanced-patches@730f3e3))
* **YT Music - Hide 'Get Music Premium' label:** Remove occurences of label in settings ([#3046](ReVanced/revanced-patches#3046)) ([10e170a](ReVanced/revanced-patches@10e170a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Duolingo - Unlock super): App crashes with a java verify error
2 participants