Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Theme): Add option to use custom seekbar accent color #4337

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Jan 22, 2025

Allows picking a custom seekbar accent (secondary) color.

It takes some care to pick a secondary color that complements the primary color, but otherwise works as expected.

If you're not sure what accent to pick, try an accent that is a slightly brighter shade of the primary color and it usually looks good.

If you want a solid seekbar with a single color, then pick the same color for both the seekbar and the accent.

Works with 19.25+

Green

Yellow red

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/custom_gradient_seekbar branch from b2433be to 63696ab Compare January 22, 2025 13:15
@LisoUseInAIKyrios
Copy link
Contributor Author

The splash screen animation still shows only the primary seekbar color and not the accent color.

Fixing that requires figuring out how to selectively modify the colors in a Lottie animation json file.

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/custom_gradient_seekbar branch from a87fa0a to ca25e3d Compare January 22, 2025 13:59
@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

…f to minimize the chance of patch bugs on by default
@MarcaDian

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/custom_gradient_seekbar branch from c8f71bc to cb2914b Compare January 23, 2025 13:20
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/custom_gradient_seekbar branch from cb2914b to 08fdae0 Compare January 23, 2025 13:21
@LisoUseInAIKyrios

This comment was marked as resolved.

@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

This reverts commit ef1114a.
@MarcaDian

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 952b4fc into ReVanced:dev Jan 23, 2025
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the feat/custom_gradient_seekbar branch January 23, 2025 20:15
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
# [5.10.0-dev.1](v5.9.1-dev.4...v5.10.0-dev.1) (2025-01-23)

### Features

* **YouTube - Theme:** Add option to use custom seekbar accent color ([#4337](#4337)) ([952b4fc](952b4fc))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-31)

### Bug Fixes

* **SwissId - Play integrity Removal:** Add recommended app version ([#4370](#4370)) ([d8ed474](d8ed474))
* Use correct path to fix invalid file paths ([5ff4ee8](5ff4ee8))
* **YouTube - Hide ads:** fix 'Hide the Visit store button on channel pages' not working ([#4364](#4364)) ([9d63ea9](9d63ea9))
* **YouTube - Hide Ads:** Hide end screen store banner without leaving empty space ([#4367](#4367)) ([7e68390](7e68390))
* **YouTube - Hide ads:** Hide new types of tablet ads ([574bcc8](574bcc8))
* **YouTube - Hide layout components:** Hide new kind of community post ([#4341](#4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([#4333](#4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Spoof video streams:** Update settings side effects summary text ([#4369](#4369)) ([e5b3aa1](e5b3aa1))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([#4329](#4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([#4351](#4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([#4355](#4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([#4337](#4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([#4347](#4347)) ([0528f7c](0528f7c))
@MarcaDian
Copy link
Contributor

MarcaDian commented Feb 1, 2025

Some patchers have implemented color selection from a color palette, it may be interesting for you to implement.
anddea/revanced-patches@bd0aa09

Screenshot_2025-02-02-01-01-19-583_anddea youtube-edit
Screenshot_2025-02-02-01-01-44-064_anddea youtube

@MarcaDian
Copy link
Contributor

MarcaDian commented Feb 5, 2025

@LisoUseInAIKyrios
Hello, I adapted the code above ( commit MarcaDian@16138f3 ), should I create a PR to add or is it not very interesting?

Previously, it was written that it is better to ask, so as not to waste time.

Screenshot_2025-02-05-18-00-58-248_app revanced android youtube
Screenshot_2025-02-05-18-07-36-783_app revanced android youtube
Screenshot_2025-02-05-18-01-13-989_app revanced android youtube

@LisoUseInAIKyrios
Copy link
Contributor Author

I was in the process of writing a color picker with some changes. It would be useful if SponsorBlock also used the same color picker (might require refactoring and modernizing the SB color settings).

Wait a week and if I don't have time to finish what I have then we can modify and integrate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants