Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Hide video description components): Add Hide How this content was made section #4355

Conversation

ILoveOpenSourceApplications
Copy link
Contributor

Closes #4354.

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube - Hide video description components): Add Hide How this was made section feat(YouTube - Hide video description components): Add Hide How this content was made section Jan 25, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 68ec54e into ReVanced:dev Jan 27, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
# [5.10.0-dev.4](v5.10.0-dev.3...v5.10.0-dev.4) (2025-01-27)

### Features

* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([#4355](#4355)) ([68ec54e](68ec54e))
@ILoveOpenSourceApplications ILoveOpenSourceApplications deleted the feat/hide-how-this-was-made-section branch January 27, 2025 09:33
@cyberboh
Copy link

@LisoUseInAIKyrios After recent dev release i get error while patching and compiling

INFO: Compiling modified resources
WARNING: warn: removing resource app.revanced.android.youtube:string/revanced_seekbar_custom_color_value_summary without required default value.
WARNING: warn: removing resource app.revanced.android.youtube:string/revanced_seekbar_custom_color_value_title without required default value.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\apk\res\xml\revanced_prefs.xml:1: error: resource string/revanced_hide_how_this_was_made_section_summary_off (aka app.revanced.android.youtube:string/revanced_hide_how_this_was_made_section_summary_off) not found.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\apk\res\xml\revanced_prefs.xml:1: error: resource string/revanced_hide_how_this_was_made_section_summary_on (aka app.revanced.android.youtube:string/revanced_hide_how_this_was_made_section_summary_on) not found.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\apk\res\xml\revanced_prefs.xml:1: error: resource string/revanced_hide_how_this_was_made_section_title (aka app.revanced.android.youtube:string/revanced_hide_how_this_was_made_section_title) not found.
WARNING: error: failed linking file resources.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Users\AppData\Local\Temp\brut_util_Jar_159109482657625091287017521849254535267.tmp, link, -o, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\patched\resources\resources.apk, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 35, --version-code, 1550190016, --version-name, 19.50.40, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --warn-manifest-validation, -e, C:\Users\Users\AppData\Local\Temp\APKTOOL6351039788148726370.tmp, -0, arsc, -I, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\1.apk, --manifest, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\apk\AndroidManifest.xml, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\apk\build\resources.zip]
        at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:249)
        at brut.androlib.AaptInvoker.invokeAapt(AaptInvoker.java:394)
        at app.revanced.patcher.patch.ResourcePatchContext.get(ResourcePatchContext.kt:133)
        at app.revanced.patcher.Patcher.get(Patcher.kt:159)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:327)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Users\AppData\Local\Temp\brut_util_Jar_159109482657625091287017521849254535267.tmp, link, -o, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\patched\resources\resources.apk, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 35, --version-code, 1550190016, --version-name, 19.50.40, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --warn-manifest-validation, -e, C:\Users\Users\AppData\Local\Temp\APKTOOL6351039788148726370.tmp, -0, arsc, -I, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\1.apk, --manifest, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\apk\AndroidManifest.xml, E:\ANDROID\APPS\ReVanced\Patched\Install\YouTube_19.50.40-all_ReVanced-temporary-files\patcher\apk\build\resources.zip]
        at brut.util.OS.exec(OS.java:104)
        at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:245)
        ... 13 more

Is the error caused by translation not merged yet?

@LisoUseInAIKyrios
Copy link
Contributor

The strings in this PR have the wrong key names

https://github.com/ILoveOpenSourceApplications/revanced-patches/blob/ddfafa9adc4ca2c5845e41655d7103a81415b8bc/patches/src/main/resources/addresources/values/strings.xml#L290-L292

It needs a fix

@ILoveOpenSourceApplications
Copy link
Contributor Author

@LisoUseInAIKyrios
Copy link
Contributor

I'll fix in a moment.

github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
# [5.10.0](v5.9.0...v5.10.0) (2025-01-31)

### Bug Fixes

* **SwissId - Play integrity Removal:** Add recommended app version ([#4370](#4370)) ([d8ed474](d8ed474))
* Use correct path to fix invalid file paths ([5ff4ee8](5ff4ee8))
* **YouTube - Hide ads:** fix 'Hide the Visit store button on channel pages' not working ([#4364](#4364)) ([9d63ea9](9d63ea9))
* **YouTube - Hide Ads:** Hide end screen store banner without leaving empty space ([#4367](#4367)) ([7e68390](7e68390))
* **YouTube - Hide ads:** Hide new types of tablet ads ([574bcc8](574bcc8))
* **YouTube - Hide layout components:** Hide new kind of community post ([#4341](#4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([#4333](#4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Spoof video streams:** Update settings side effects summary text ([#4369](#4369)) ([e5b3aa1](e5b3aa1))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([#4329](#4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([#4351](#4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([#4355](#4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([#4337](#4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([#4347](#4347)) ([0528f7c](0528f7c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(YouTube - Hide video description components): Hide 'How this content was made' section
3 participants