-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrollHide not hiding tooltip on mobile #248
Comments
|
+1 to scrollHide not working (on desktop), not using a single top-level element. |
Hey guys, can this issue be reproduced at the examples page? Please, provide more information how to reproduce this. |
to clarify @philraj and along with what @ajritch said, I'm not using this as a top level element at all. It's actually being used on a table that lazy loads rows "Fixed-Data-Table" to be exact. I ended up re writing the table and building my own tooltip. haha good ol' fashioned work around/work through. @huumanoid to reproduce, simply install the element, hover to activate and show the tooltip, and start scrolling. It wont go away. :) |
@huumanoid No, can't reproduce it with the examples given. It might be because I'm using the tooltips within I am using a single |
Thanks guys. I think I've catched it. I'm going to fix it in 3.2.11 or 3.2.12. <div id="root">
<ReactTooltip />
<div style={{ width: '5000px'; height: '5000px' }} />
</div> |
This problem solved? |
I believe so. Should I close the issue? |
@ryanhca I see this bug in the current version. |
Based on a comment in #291, there is a work-around. add |
🎉 This issue has been resolved in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@aronhelser As of Ah, I see it is only failing to work when you set a |
I'm not sure I understand, but it could be. What behavior do you expect if you set both delayHide and scrollHide? Based on the behavior of the tooltip in the "Theme and Delay" section of the demo (http://wwayne.com/react-tooltip/) I think the tooltip hanging around for the delay after a scroll is the expected behavior. |
@aronhelser I wouldn't think so. If a user scrolls down the page for several seconds (slowly, or it's a large page) the tooltip will remain positioned in its static position on the page for the entire time. It's really odd looking (ie, looks buggy) to just have it hanging out there for the entire duration of the scroll. For me it should disappear after scroll-start + delay, or have its own delay entirely. |
Can you file a new issue?
…On Thu, Jun 7, 2018 at 5:59 PM, Thomas Hibbard ***@***.***> wrote:
@aronhelser <https://github.com/aronhelser> I wouldn't think so. If a
user scrolls down the page for several seconds (slowly, or it's a large
page) the tooltip will remain positioned in its static position on the page
for the entire time. It's really odd looking (ie, looks buggy) to just have
it hanging out there for the entire duration of the scroll. For me it
should disappear after scroll-start + delay, or have its own delay entirely.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AS_pneOra_fh7iwHvkpVJ3aU2VHEWcXnks5t6aJYgaJpZM4Lx_LX>
.
|
I am still facing this issue in |
We are still see this issue in |
I am still see this issue in
|
I think this issue arising due to combination of delayHide and scroll is being tracked under #474, for others who stumble here on this issue for this, lets use Issue 474 for adding comments, up-voting and further analysis/PR. |
If the event target is an SVG, the tooltip will appear only on hovering over the strokes. svg {
pointer-events: all;
} |
The issue is still there, even on desktop. |
I'm experiencing this issue on desktop as well. v4.2.21 - super vexing since I rely heavily on z-index manipulation so not being able to hide on scroll would hinder our users' experience. |
I'm assuming this has something to do with the "hover" event since there isn't really one in Mobile. I'm wondering if anyone else has run into this problem and come up with a solution, I don't want to have to add eventHandlers all over to capture the scroll event.
Here is an example of my code:
I'm trying to use the scrollHide and scrollResize events according to docs.
The text was updated successfully, but these errors were encountered: