Add ability to specify custom DOM element for scrollHide scroll events
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`window` works in most cases, but for tooltips rendered within larger elements that contain `overflow: scroll`, the scroll events don’t fire on the window. This allows specifying a custom selector to get a different scroll container other than the window
|
Useful PR |
|
For anyone running into this issue, setting the isCapture prop will allow the window scroll listener to catch scroll events on a div when using overflow: scroll. (Supported in IE9+). |
|
Confirmed that setting isCapture fixes the issue. Perhaps we should make isCapture the default? |
|
Handled by isCapture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just started using
react-tooltipthis week, really awesome library - thank you guys!Currently,
scrollHidejust looks for scrollEvents on thewindow. This works well 99% of the time, but if a page has custom scroll containers, thewindownever actually sees any of those scroll events, as they're not fired on thewindow.This PR just adds a way to plug in a custom selector to replace the window - I don't believe it fixes every problem of #248, but it should act as an easy workaround for situations like @philraj was having here.
I haven't been following the project closely, so I hope this is the proper way to contribute. Thanks!