-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: package export files #1005
Conversation
Beta version:
or
|
Beta version:
or
|
Something to consider, is it viable to internally import the CSS file? So when using the component you no longer need to import 'react-tooltip/dist/react-tooltip.css' |
I was thinking about it in the past, the great point is if the dev wants to fully customize the CSS, they can just not import our file and create one from scratch, but as far as we are seeing, they normally expect to see the tooltip without add our CSS file. We can add the CSS directly, will this be a major release (this change will not break the app, they just do not need to import the CSS manually anymore)? I believe it's better to do a new PR to handle this change. |
I just started tinkering with react-tooltip and I'd also prefer react-tooltip to preload any css styles. importing css file especially in shadow dom on top of custom webpack loader is PITA. |
close #1004
close #1002
close #1000
close #987