Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package export files #1005

Merged
merged 4 commits into from
Apr 10, 2023
Merged

fix: package export files #1005

merged 4 commits into from
Apr 10, 2023

Conversation

danielbarion
Copy link
Member

@danielbarion danielbarion commented Apr 7, 2023

  • update rollup-build to output missed normal CSS file

close #1004
close #1002
close #1000
close #987

@danielbarion
Copy link
Member Author

Beta version:

yarn add react-tooltip@5.10.6-beta.1005.1

or

npm i react-tooltip@5.10.6-beta.1005.1

@danielbarion
Copy link
Member Author

Beta version:

yarn add react-tooltip@5.10.6-beta.1005.2

or

npm i react-tooltip@5.10.6-beta.1005.2

@gabrieljablonski
Copy link
Member

gabrieljablonski commented Apr 9, 2023

Something to consider, is it viable to internally import the CSS file? So when using the component you no longer need to

import 'react-tooltip/dist/react-tooltip.css'

@danielbarion
Copy link
Member Author

Something to consider, is it viable to internally import the CSS file? So when using the component you no longer need to

import 'react-tooltip/dist/react-tooltip.css'

I was thinking about it in the past, the great point is if the dev wants to fully customize the CSS, they can just not import our file and create one from scratch, but as far as we are seeing, they normally expect to see the tooltip without add our CSS file.

We can add the CSS directly, will this be a major release (this change will not break the app, they just do not need to import the CSS manually anymore)? I believe it's better to do a new PR to handle this change.

@gabrieljablonski gabrieljablonski merged commit d7a9860 into master Apr 10, 2023
@gabrieljablonski gabrieljablonski deleted the fix/package-export-files branch April 10, 2023 19:34
@GorvGoyl
Copy link

GorvGoyl commented Apr 11, 2023

Something to consider, is it viable to internally import the CSS file? So when using the component you no longer need to

import 'react-tooltip/dist/react-tooltip.css'

I just started tinkering with react-tooltip and I'd also prefer react-tooltip to preload any css styles. importing css file especially in shadow dom on top of custom webpack loader is PITA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants