-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint warning: Package subpath './dist/react-tooltip' is not defined #987
Comments
hi @binomialstew can you check our PRs and the comments (beta releases) and let me know if the latest beta releases work for you? #984 #982 |
I still see this issue in both I think this should be added to package exports: |
Hey @binomialstew Following up on this issue, could you please test |
@gabrieljablonski, I do still see this warning using |
Whenever you get the time, if you could provide a sample repository where we can reproduce this warning, it would help us immensely. |
@gabrieljablonski, here you go. If you clone it and run |
Thanks for taking the time. Can confirm that editing the
fixes it, though I'm not sure if This issue (#987) along with #1000 and #1002 can definitely all be fixed together. Whenever @danielbarion has the time, he'll look into fixing all of these properly. Thanks for reporting! |
Confirmed. Both Thanks for taking care of it! |
Hi, can you test this beta release and let us know, please? Beta version:
or
PS: I didn't add the entry that @gabrieljablonski mentioned in this beta release, but if this one doesn't work, I can add and release a new beta version. |
@danielbarion , |
thanks for confirming @binomialstew And this one? Beta version:
or
Commit: 74327ca |
This fixes it, yes. |
Is this fixed in v5.10.6. |
Please test the official release |
This doesn't correct the issue and I see the exports don't have the ones that are needed. In
In the one I confirmed is fixed:
|
thanks for letting us know! We'll do a new release with the exports updated soon. Edit, please check the source code, they are the same as you described: https://github.com/ReactTooltip/react-tooltip/blob/master/package.json#L37 If you need, please create a new issue, thanks! |
Describe the bug
When importing:
I see the following error through eslint:
I'm not sure exactly where './dist/react-tooltip' is being requested (not in my codebase), but adding this to the react-tooltip package
exports
resolves it:Version of Package
v5.10.1-beta.4
The text was updated successfully, but these errors were encountered: