fix: add export field into package.json

[danielbarion]

• use not minified files into package.json
• continue exporting minified files because the community can import those files directly from dist if they want
• add an export field into package.json

To try this PR just install this beta release:

yarn add react-tooltip@5.10.1-beta.5

or

npm install react-tooltip@5.10.1-beta.5

close #976
close #981

[danielbarion]

yarn add react-tooltip@5.10.1-beta.6

or

npm install react-tooltip@5.10.1-beta.6

[danielbarion]

yarn add react-tooltip@5.10.1-beta.7

or

npm install react-tooltip@5.10.1-beta.7

cc @gabrieljablonski @GerkinDev @jacogr

[GerkinDev]

I'll try it on my bug repro, and check if webpack (the oldest bundler in the place) behave correctly. Maybe later today

[GerkinDev]

#976 seems to work now
I tested a create-react-app and it worked fine too.

But #972 fails again using react-tooltip@5.10.1-beta-7. Digging in

[GerkinDev]

#972 regression

[GerkinDev]

See #972 (comment) for investigation results. They seem to indicate that pointing to non-minified version is not a reliable solution to the issue.

[danielbarion]

yarn add react-tooltip@5.10.1-beta-8

or

npm install react-tooltip@5.10.1-beta-8

@GerkinDev this beta release is pointing to minified files

[GerkinDev]

This time also, works with both minified & unminified (I modified the package.json of installed version) with swcMinify: false, but does not work with both minified & unminified with swcMinify: true or unset.

By setting a breakpoint in the repro app, somehow, swc reassigns the react import to a number....
See the value of a:
1st call:

2nd call:

[GerkinDev]

Honestly I don't know how to reliably fix the issue. Given that some builds seems to work, while some other don't, only with swc, I have the feeling that it's somewhat related to a bug in the mangling map of swc. The shortest reliable solution I've found is swcMinify: false. Yet, I understand this is not a satisfying one

I've tracked down the faulty reassignation from within the bundled @floating-ui/core that somehow assign a number to the react import after minification. Awkward ? Yes it is, that's why I think it's a bug on THEIR side. It might be worth to try again with @floating-ui marked external, so that swc handles module linking itself. But I could not guarantee this would be a reliable solution even if it works.

That kind of issue is a hell.

[danielbarion]

@GerkinDev can you confirm if the bug is happening on 5.8.3? Maybe the solution is we back to rollup as a default bundler.

5.8.3 - Rollup - ~ 14kb (final files sizes)
5.9.0 - Esbuild - ~ 9kb (final files sizes)

PR: #959

[GerkinDev]

I'll explore that. Also, I'll do tests with other versions of next.js, maybe it's a regression in a dependency or it might have been patched in the meantime.

[jeyang]

Confirming that it's working for me in 5.8.3

[danielbarion]

@jeyang can you test this beta release and let me know if it's working, please?

yarn add react-tooltip@5.10.1-beta-9

or

npm install react-tooltip@5.10.1-beta-9

This beta version was built with rollup instead of esbuild

[jeyang]

for react-tooltip@5.10.1-beta-9 I'm getting this error message:

./node_modules/react-tooltip/dist/react-tooltip.min.mjs
Can't import the named export 'createContext' from non EcmaScript module (only default export is available)

[danielbarion]

@jeyang can you test if the beta release with rollup works for you, please? (another PR)

#984 (comment)

edit: or can you provide a reproducible example, so I can test, please?

[consense]

same issue for me. It comes up when using storybook (version @storybook/react": "6.5.16)

Using normal webpack build:

• 5.8: works fine
• 5.10: works fine
• 5.10.1-beta-9: works fine

Using storybook

• 5.8: works fine
• 5.10: Error: Module parse failed: Unexpected token
• 5.10.1-beta-9: ModuleDependencyError: Can't import the named export 'createContext' from non EcmaScript module (only default export is available)

[danielbarion]

Please check my comment at: #984 (comment)