-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add esbuild as bundler #959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbarion
commented
Feb 22, 2023
We can test this guy which uses Esbuild to build the package (to build the types and the distribution files in one build) |
Can you add source maps at the same time? I'm trying to debug a tooltip that isn't showing up. |
@r3m0t source map added to the build (only for this PR at the moment) |
danielbarion
force-pushed
the
feat/esbuild
branch
from
March 4, 2023 23:07
dc1653b
to
171e138
Compare
gabrieljablonski
approved these changes
Mar 5, 2023
gabrieljablonski
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to generate the types with Esbuild- directly is not possible16
instead of18
cra-app
) folder when it's not used anymorehttps://npmtrends.com/esbuild-vs-rollup-vs-snowpack-vs-swc-vs-vite