Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add esbuild as bundler #959

Merged
merged 21 commits into from
Mar 5, 2023
Merged

feat: add esbuild as bundler #959

merged 21 commits into from
Mar 5, 2023

Conversation

danielbarion
Copy link
Member

@danielbarion danielbarion commented Feb 22, 2023

  • Add Esbuild to the project
  • Make the development build with esbuild work like the development build with rollup
  • Make the production build with esbuild work like the production build with rollup
  • Try to generate the types with Esbuild - directly is not possible
  • Check the filesize of the files to see if the esbuild is lighter than rollup generated files
  • Check if all examples in docs are working as expected
  • Check if tests are working as expected
  • Add live reload to dev environment

  • Revert React version to use 16 instead of 18
  • Remove create-react-app (cra-app) folder when it's not used anymore

https://npmtrends.com/esbuild-vs-rollup-vs-snowpack-vs-swc-vs-vite

.gitignore Show resolved Hide resolved
cra-app/src/App.js Outdated Show resolved Hide resolved
docs/.gitignore Show resolved Hide resolved
docs/package.json Outdated Show resolved Hide resolved
esbuild.config.dev.mjs Outdated Show resolved Hide resolved
esbuild.config.prod.mjs Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@danielbarion
Copy link
Member Author

@gabrieljablonski

We can test this guy which uses Esbuild to build the package (to build the types and the distribution files in one build)
https://www.npmjs.com/package/estrella

@r3m0t
Copy link

r3m0t commented Mar 2, 2023

Can you add source maps at the same time? I'm trying to debug a tooltip that isn't showing up.

@danielbarion
Copy link
Member Author

@r3m0t source map added to the build (only for this PR at the moment)

@danielbarion
Copy link
Member Author

image

@danielbarion danielbarion marked this pull request as ready for review March 4, 2023 23:34
esbuild.config.prod.mjs Show resolved Hide resolved
esbuild.config.prod.mjs Outdated Show resolved Hide resolved
esbuild.config.prod.mjs Outdated Show resolved Hide resolved
@danielbarion danielbarion merged commit 35d0e48 into master Mar 5, 2023
@danielbarion danielbarion deleted the feat/esbuild branch March 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants