Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealloc disposable improvements #580

Merged
merged 10 commits into from
Jun 14, 2013
Merged

Dealloc disposable improvements #580

merged 10 commits into from
Jun 14, 2013

Conversation

jspahrsummers
Copy link
Member

Includes the following high-level changes:

  • Moved everything deallocation-related into NSObject+RACDeallocating.
  • Dealloc disposables are now torn down in a swizzled -dealloc, not as an associated object (which happens later, and can cause use-after-free errors).
  • RACKVOTrampoline is now a RACDisposable, so it can reuse the dealloc disposable machinery really easily.
  • Added -rac_willDeallocSignal to complement/replace -rac_didDeallocSignal (see also Remove -rac_didDeallocSignal #579).

@Coneko
Copy link
Member

Coneko commented Jun 14, 2013

Note this also fixes #463.

@joshaber
Copy link
Member

Suuuuuuuuuuure.

joshaber added a commit that referenced this pull request Jun 14, 2013
@joshaber joshaber merged commit abcba22 into master Jun 14, 2013
@joshaber joshaber deleted the dealloc-fixes branch June 14, 2013 01:10
@jspahrsummers jspahrsummers mentioned this pull request Jun 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants