SignalProducer.on: restore value
as the last parameter
#104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually,
value
should be defined beforefailed
since that goes in line with the natural order of events, however this reordering can introduce some confusion/inconvenience while using trailing closures specially during the migration from ReactiveCocoa 4.x wherevalue
, formerly known asnext
, was the last parameter and now representsdisposed
.This can silently introduce some problems after migration if a project is using
.on
with a trailing closure to inject side-effects on values without being interested in the value itself.If we do not go forward with this we need to fix an inconsistency between
SignalProducer
andSignal
where the former was not updated accordingly.