Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalProducer.on: restore value as the last parameter #104

Merged
merged 1 commit into from
Nov 24, 2016
Merged

SignalProducer.on: restore value as the last parameter #104

merged 1 commit into from
Nov 24, 2016

Commits on Nov 22, 2016

  1. SignalProducer.on: restore value as the last parameter 

    Conceptually, `value` should be defined before `failed` since that goes
in line with the natural order of events, however this reordering can
introduce some confusion/inconvenience while using trailing closures
specially during the migration from ReactiveCocoa 4.x.

There's also an inconsistency between `SignalProducer` and `Signal`
where the former was not updated accordingly.
    @dmcrodrigues
    dmcrodrigues committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    70a09c9 View commit details
    Browse the repository at this point in the history