Failing test cases for race conditions in signal interruption (#123). #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
changed the title
NachoSoto
requested changes
Nov 26, 2016
| signal.observe { event in | ||
| if !hasSlept { | ||
| sema.signal() | ||
| sleep(5) |
There was a problem hiding this comment.
Does this artificially add 5 seconds to the test? If so, 👎 that's too high of a price to pay.
|
I don't think I've tuned them down though. The post-termination event test case now stalls only for 0.125 seconds, while the concurrent interruption test case now takes only 1000 iterations with 5 second timeout on the counter. |
|
👍
On Sat, Nov 26, 2016 at 08:19 Anders Ha ***@***.***> wrote:
I don't think Scheduler suits here. TestScheduler is synchronous, while
QueueScheduler is serialising.
I've shortened the time though. The post-termination event test case now
stalls only for 0.125 seconds, while the concurrent interruption test case
now takes only 1000 iterations with 5 second timeout on the counter.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#125 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAp2KVKKmRwN3lmNRxaIyRCb2mOZTtimks5rCFwQgaJpZM4K8wRh>
.
--
Ignacio Soto
|
andersio
force-pushed
the
signal-failing-testcases
branch
from
b2e8b48
to
55c9537
Compare
|
(Just made to demonstrate the failure. Further changes will be made in #123.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in #123.
Note that the test case "should interrupt concurrently" may not fail on Travis CI due to the limited concurrency. Running the test case locally should yield the expected result.