Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test cases for race conditions in signal interruption (#123). #125

Merged
merged 3 commits into from
Nov 27, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions Tests/ReactiveSwiftTests/SignalSpec.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

import Foundation
import Dispatch

import Result
import Nimble
Expand Down Expand Up @@ -213,6 +214,97 @@ class SignalSpec: QuickSpec {
}
}

describe("interruption") {
it("should not send events after sending an interrupted event") {
let queue: DispatchQueue
let counter = Atomic<Int>(0)

if #available(macOS 10.10, *) {
queue = DispatchQueue.global(qos: .userInitiated)
} else {
queue = DispatchQueue.global(priority: .high)
}

let (signal, observer) = Signal<Int, NoError>.pipe()

var hasSlept = false
var events = [Event<Int, NoError>]()

let sema = DispatchSemaphore(value: 0)

signal.observe { event in
if !hasSlept {
sema.signal()
// 100000 us = 0.1 s
usleep(100000)
hasSlept = true
}
events.append(event)
}

let group = DispatchGroup()

DispatchQueue.concurrentPerform(iterations: 10) { index in
queue.async(group: group) {
observer.send(value: index)
}

if index == 0 {
sema.wait()
observer.sendInterrupted()
}
}

group.wait()

expect(events.count) == 2
expect(events.count >= 2 ? events[1].isTerminating : false) == true
}

it("should interrupt concurrently") {
let queue: DispatchQueue
let counter = Atomic<Int>(0)
let executionCounter = Atomic<Int>(0)

if #available(macOS 10.10, *) {
queue = DispatchQueue.global(qos: .userInitiated)
} else {
queue = DispatchQueue.global(priority: .high)
}

let iterations = 1000
let group = DispatchGroup()

queue.async(group: group) {
DispatchQueue.concurrentPerform(iterations: iterations) { _ in
let (signal, observer) = Signal<(), NoError>.pipe()

var isInterrupted = false
signal.observeInterrupted { counter.modify { $0 += 1 } }

let sema = DispatchSemaphore(value: 0)

queue.async(group: group) {
sema.signal()
observer.send(value: ())
executionCounter.modify { $0 += 1 }
}

queue.async(group: group) {
sema.wait()
observer.sendInterrupted()
executionCounter.modify { $0 += 1 }
}
}
}

group.wait()

expect(executionCounter.value) == iterations * 2
expect(counter.value).toEventually(equal(iterations), timeout: 5)
}
}

describe("observe") {
var testScheduler: TestScheduler!

Expand Down