Creating toObservable for Future #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code looks fine, though I'm curious about the implication of it blocking on the Future.get(). It's obviously the only way to do it without spawning another thread that blocks on that future which would take us into this conversation: #19 Is this misleading to people to think it would be asynchronous? |
| @Override | ||
| public Subscription call(Observer<T> observer) { | ||
| try { | ||
| T value = that.get(); |
There was a problem hiding this comment.
Perhaps we should add an overload that allows passing in the timeout values?
|
I've added comments inline in the code as well |
|
Looks good. |
benjchristensen
added a commit
that referenced
this pull request
Jan 31, 2013
Creating toObservable for Future
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Creating toObservable for Future
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple wrapper that turns a future into a observable.